Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Resolve an existing defect when restoring from snapshots #2249

Merged
merged 2 commits into from
Nov 18, 2024
Merged

Resolve an existing defect when restoring from snapshots #2249

merged 2 commits into from
Nov 18, 2024

Conversation

tian-lt
Copy link
Contributor

@tian-lt tian-lt commented Nov 13, 2024

Verified test cases:

  1. empty state.
  2. number
  3. number + operator
  4. number + operator + =
  5. error without expressions
  6. error with expressions

@guominrui
Copy link
Member

Input 0 / 2, press Enter. After restoring, the error message doesn't show.

@tian-lt
Copy link
Contributor Author

tian-lt commented Nov 18, 2024

Input 0 / 2, press Enter. After restoring, the error message doesn't show.

Nice catch! Fixed.

@tian-lt tian-lt merged commit 2b0521e into microsoft:main Nov 18, 2024
5 checks passed
@tian-lt tian-lt deleted the u/tilia/fixdup branch November 18, 2024 10:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@guominrui guominrui guominrui approved these changes

@hanzhang54 hanzhang54 Awaiting requested review from hanzhang54

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@tian-lt @guominrui