Docs: Add 'Change Event Callback' pattern doc #33216
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
📊 Bundle size report✅ No changes found |
mltejera
approved these changes
Nov 7, 2024
📊 Bundle size report✅ No changes found |
|
Pull request demo site: URL |
mltejera
approved these changes
Nov 7, 2024
| * @param data - A data object with relevant information, | ||
| * such as open value and type of interaction that created the event | ||
| */ | ||
| // eslint-disable-next-line @nx/workspace-consistent-callback-type -- can't change type of existing callback |
There was a problem hiding this comment.
This is a deprecated callback type. What about use an example that uses the new callback type? For example TagPicker onOpenChange?
There was a problem hiding this comment.
I see the first example is all taken from dialog. So maybe just add a comment somewhere here pointing to a component that uses the new type like TagPicker
There was a problem hiding this comment.
Good catch thank you! I'll replace this with the latest
marcosmoura
approved these changes
Nov 15, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Implementation of Change Event pattern to document avoiding potential breaking changes and recommended architecture.