Class View Search Case Fix (#2498)

* search case fix * auto lint fixes
microsoft · Jan 23, 2024 · 01cb9d5 · 01cb9d5
1 parent 4cd7c79
commit 01cb9d5
Show file tree

Hide file tree

Showing 8 changed files with 22 additions and 16 deletions.
diff --git a/libs/core-ui/src/lib/util/getFeatureOptions.ts b/libs/core-ui/src/lib/util/getFeatureOptions.ts
@@ -31,7 +31,7 @@ export function getFeatureOptions(
       return {
         data: {
           categoricalOptions: options,
-          fullLabel: meta.label.toLowerCase()
+          fullLabel: meta.label.toLocaleLowerCase()
         },
         key,
         text: meta.abbridgedLabel

diff --git a/libs/fairness/src/lib/Controls/Insights.tsx b/libs/fairness/src/lib/Controls/Insights.tsx
@@ -83,11 +83,11 @@ export class Insights extends React.Component<IInsightsProps> {
     // description of model with best performance
     const insights3 = localization.formatString(
       localization.Fairness.ModelComparison.insightsText3,
-      this.props.selectedMetric.title.toLowerCase(),
+      this.props.selectedMetric.title.toLocaleLowerCase(),
       this.props.selectedMetric.isMinimization
         ? formattedMinPerformance
         : formattedMaxPerformance,
-      this.props.selectedFairnessMetric.title.toLowerCase(),
+      this.props.selectedFairnessMetric.title.toLocaleLowerCase(),
       FormatMetrics.formatNumbers(
         this.props.fairnessArray[
           this.props.selectedMetric.isMinimization
@@ -101,12 +101,12 @@ export class Insights extends React.Component<IInsightsProps> {
     // description of model with best fairness metric value
     const insights4 = localization.formatString(
       localization.Fairness.ModelComparison.insightsText4,
-      this.props.selectedMetric.title.toLowerCase(),
+      this.props.selectedMetric.title.toLocaleLowerCase(),
       FormatMetrics.formatNumbers(
         this.props.performanceArray[minFairnessValueIndex],
         this.props.selectedPerformanceKey
       ),
-      this.props.selectedFairnessMetric.title.toLowerCase(),
+      this.props.selectedFairnessMetric.title.toLocaleLowerCase(),
       formattedMinFairnessValue
     );
 

diff --git a/libs/interpret-vision/src/lib/VisionExplanationDashboard/Controls/CohortToolBar.tsx b/libs/interpret-vision/src/lib/VisionExplanationDashboard/Controls/CohortToolBar.tsx
@@ -59,7 +59,7 @@ export class CohortToolBar extends React.Component<
   public componentDidMount(): void {
     const cohortNames: string[] = [];
     this.props.cohorts.forEach((cohort: ErrorCohort) => {
-      cohortNames.push(cohort.cohort.name.toLowerCase());
+      cohortNames.push(cohort.cohort.name.toLocaleLowerCase());
     });
     const selectionCount: number = this.props.selectedIndices.length;
     this.setState({ cohortNames, selectionCount });
@@ -72,7 +72,7 @@ export class CohortToolBar extends React.Component<
     if (prevProps.cohorts !== this.props.cohorts) {
       const cohortNames: string[] = [];
       this.props.cohorts.forEach((cohort: ErrorCohort) => {
-        cohortNames.push(cohort.cohort.name.toLowerCase());
+        cohortNames.push(cohort.cohort.name.toLocaleLowerCase());
       });
       this.setState({ cohortNames });
     }
@@ -180,7 +180,9 @@ export class CohortToolBar extends React.Component<
       this.setState({
         errorMessage: localization.InterpretVision.Cohort.errorNumSelected
       });
-    } else if (this.state.cohortNames.includes(cohortName.toLowerCase())) {
+    } else if (
+      this.state.cohortNames.includes(cohortName.toLocaleLowerCase())
+    ) {
       this.setState({
         errorMessage: localization.InterpretVision.Cohort.errorCohortName
       });

diff --git a/libs/interpret-vision/src/lib/VisionExplanationDashboard/Controls/ImageList.tsx b/libs/interpret-vision/src/lib/VisionExplanationDashboard/Controls/ImageList.tsx
@@ -88,7 +88,7 @@ export class ImageList extends React.Component<
   }
 
   private getFilteredItems(): IVisionListItem[] {
-    const searchValue = this.props.searchValue.toLowerCase();
+    const searchValue = this.props.searchValue.toLocaleLowerCase();
     let filteredItems: IVisionListItem[] = this.props.items;
     if (searchValue.length > 0) {
       filteredItems = getFilteredDataFromSearch(

diff --git a/libs/interpret-vision/src/lib/VisionExplanationDashboard/Controls/TableList.tsx b/libs/interpret-vision/src/lib/VisionExplanationDashboard/Controls/TableList.tsx
@@ -53,7 +53,7 @@ export class TableList extends React.Component<
       this.props.searchValue !== prevProps.searchValue
     ) {
       const filteredItems: IVisionListItem[] = this.getFilteredItems();
-      const searchVal = this.props.searchValue.toLowerCase();
+      const searchVal = this.props.searchValue.toLocaleLowerCase();
       const groups: IGroup[] =
         searchVal.length === 0
           ? this.getGroups()
@@ -118,7 +118,7 @@ export class TableList extends React.Component<
 
     items = items.concat(this.props.successInstances);
     items = items.concat(this.props.errorInstances);
-    const searchValue = this.props.searchValue.toLowerCase();
+    const searchValue = this.props.searchValue.toLocaleLowerCase();
     if (searchValue.length === 0) {
       return items;
     }
@@ -155,7 +155,7 @@ export class TableList extends React.Component<
     filteredItems: IVisionListItem[],
     groups: IGroup[]
   ): IGroup[] {
-    const searchValue = this.props.searchValue.toLowerCase();
+    const searchValue = this.props.searchValue.toLocaleLowerCase();
     if (searchValue.length === 0) {
       return groups;
     }

diff --git a/libs/interpret-vision/src/lib/VisionExplanationDashboard/utils/getFilteredData.ts b/libs/interpret-vision/src/lib/VisionExplanationDashboard/utils/getFilteredData.ts
@@ -39,7 +39,9 @@ export function includesSearchVal(
   searchVal: string
 ): boolean {
   if (Array.isArray(labels)) {
-    return labels.some((label) => label.toLowerCase().includes(searchVal));
+    return labels.some((label) =>
+      label.toLocaleLowerCase().includes(searchVal.toLocaleLowerCase())
+    );
   }
-  return labels.toLowerCase().includes(searchVal);
+  return labels.toLocaleLowerCase().includes(searchVal.toLocaleLowerCase());
 }
diff --git a/...assessment/src/lib/ModelAssessmentDashboard/Controls/ModelOverview/CohortStatsHeatmap.tsx b/...assessment/src/lib/ModelAssessmentDashboard/Controls/ModelOverview/CohortStatsHeatmap.tsx
@@ -151,7 +151,9 @@ export class CohortStatsHeatmap extends React.Component<
                     localization.ModelAssessment.ModelOverview
                       .tableMetricTooltip,
                     // make metric name lower case in sentence
-                    this.series.xAxis.categories[this.point.x].toLowerCase(),
+                    this.series.xAxis.categories[
+                      this.point.x
+                    ].toLocaleLowerCase(),
                     cohortNameBold,
                     pointValue === null
                       ? localization.ModelAssessment.ModelOverview.nA

diff --git a/...ssessment/src/lib/ModelAssessmentDashboard/Controls/ModelOverview/FairnessMetricTable.tsx b/...ssessment/src/lib/ModelAssessmentDashboard/Controls/ModelOverview/FairnessMetricTable.tsx
@@ -140,7 +140,7 @@ export class FairnessMetricTable extends React.Component<
                       : localization.ModelAssessment.ModelOverview
                           .tableRatioTooltip,
                     // make metric name lower case in sentence
-                    this.series.xAxis.categories[point.x].toLowerCase(),
+                    this.series.xAxis.categories[point.x].toLocaleLowerCase(),
                     pointValue,
                     min,
                     `<b>${point.minCohort}</b>`,