add validation target column type in the classification scenario #2127
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…oat-type target column
hawestra
requested review from
gaugup,
imatiach-msft,
xuke444,
kicha0,
RubyZ10,
vinuthakaranth and
tongyu-microsoft
as code owners
gaugup
reviewed
Jun 22, 2023
Codecov Report
@@ Coverage Diff @@
## main #2127 +/- ##
==========================================
+ Coverage 91.02% 92.21% +1.19%
==========================================
Files 115 103 -12
Lines 6058 5140 -918
==========================================
- Hits 5514 4740 -774
+ Misses 544 400 -144
Flags with carried forward coverage won't be shown. Click here to find out more.
|
romanlutz
approved these changes
Jun 26, 2023
gaugup
approved these changes
Jun 26, 2023
imatiach-msft
approved these changes
Jun 26, 2023
imatiach-msft
approved these changes
Jun 27, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add validation check to ensure that the target column is not continuous (ie of type float) for multiclass classification. This is to address the following bug: Bug 2472415: [Live site bug] raise ValueError("Unknown label type: %r" % y_type) in 0.8.0 which resulted from a sklearn error.
Add unit tests for this scenario
Description
Checklist