Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Throw user exception for 'not handling missing data error' #2144

Closed
wants to merge 2 commits into from

Conversation

vinuthakaranth
Copy link
Contributor

Description

Throw user exception for 'not handling missing data error' while we revamp the general missing data handling in rai library, we catch this specific exception and ask the user to check warning logs to handle input data.

Checklist

  • I have added screenshots above for all UI changes.
  • I have added e2e tests for all UI changes.
  • Documentation was updated if it was needed.

Signed-off-by: vinutha karanth <[email protected]>
Signed-off-by: vinutha karanth <[email protected]>
@codecov-commenter
Copy link

Codecov Report

Merging #2144 (75e80bc) into main (80f4b9e) will decrease coverage by 4.38%.
The diff coverage is n/a.

❗ Current head 75e80bc differs from pull request most recent head 3e985c9. Consider uploading reports for the commit 3e985c9 to get more accurate results

@@            Coverage Diff             @@
##             main    #2144      +/-   ##
==========================================
- Coverage   92.52%   88.15%   -4.38%     
==========================================
  Files          55       17      -38     
  Lines        2127      287    -1840     
==========================================
- Hits         1968      253    -1715     
+ Misses        159       34     -125     
Flag Coverage Δ
unittests 88.15% <ø> (-4.38%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

see 38 files with indirect coverage changes

Copy link
Contributor

@gaugup gaugup left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks like Hannah has a similar PR #2143. Could we merge one PR?

@vinuthakaranth
Copy link
Contributor Author

Looks like Hannah has a similar PR #2143. Could we merge one PR?

yes, closing this PR.

Looks like Hannah has a similar PR #2143. Could we merge one PR?

yes, closing this PR

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants