fix socketio cors authentication for object detection and qa metrics requests #2455
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
imatiach-msft
requested review from
tongyu-microsoft,
vinuthakaranth,
xuke444,
RubyZ10 and
hawestra
as code owners
imatiach-msft
force-pushed
the
ilmat/fix-socket-cors-auth
branch
2 times, most recently
from
7c8f422
to
aae819d
Compare
2 similar comments
tongyu-microsoft
approved these changes
Dec 12, 2023
Advitya17
approved these changes
Dec 12, 2023
imatiach-msft
force-pushed
the
ilmat/fix-socket-cors-auth
branch
from
aae819d
to
c87cda2
Compare
3 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
On notebook VM environment in AzureML, there are errors when making socket connections to the flask service due to CORS authentication.
This PR adds the required settings in the flask backend service, specifically by accepting wss:// websocket connections, and updates the UI request to handle credentials.
One of the error messages:
Working screenshot in notebook VM environment:
Checklist