announce search results in RAI Vision dashboard toolbar for accessibility #2466
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
imatiach-msft
requested review from
gaugup,
tongyu-microsoft,
xuke444,
RubyZ10,
vinuthakaranth and
hawestra
as code owners
imatiach-msft
force-pushed
the
ilmat/fix-search-screen-reader-info
branch
from
7ee89b7
to
1190f08
Compare
|
مرحبا ميكروسوفت أود ١٠ قايق من الوقت لد علا الرسالة وانا سعيدا جدا بأن يكون
بيننا حديثا لتوضيح بعض الأمور اولا سوف اكتب بالغة العربيه بمكانك ترجمتها
واذا حببت ان يكون بيننا قوقل فلا مانع عندي وان ارت ان نتحدث بيننا الاثنين
فلامانع عندي احتاج الى بضع دقايق ١٠ لكتابه الرد عليكم شكرا لكم
في الخميس، ٢١ ديسمبر ٢٠٢٣، ٧:٢٦ م Ilya Matiach ***@***.***>
كتب:
… Description
announce search results in RAI Vision dashboard toolbar for accessibility
[Screen reader – Responsible AI Dashboard – Vision Data Explorer>Table
View]: Screen reader does not announce the search results information on
entering valid/invalid data.
User Experience:
Screen reader dependent people will not be able to know whether the
Success/Error instances data are getting filtered by the entered value or
not if the screen reader doesn't announce any updated information after
entering the valid/invalid data.
Pre-Requisite:
Turn on the NVDA.
Repro Steps:
Open RAI Dashboard
"Analyse_ model" page appears.
Navigate the "Vision Data Explorer" section, navigate the "Table View" tab
and all the controls present under it.
Navigate to the search edit field and filter the list items.
Observe whether screen reader announces the search results information on
entering valid or invalid data.
Actual Result:
Screen reader does not announce the search results information on entering
valid/invalid data.
Observation:
On entering valid/invalid data in the search edit field, the screen reader
remains silent.
On entering valid/invalid data in the search edit field, NVDA and JAWS
screen readers remain silent.
Expected Result:
Screen reader should announce the search results information on entering
valid/invalid data.
Example: On entering valid data such as "can", the screen reader should
announce as “9 result found for the entered keyword can where success
instances are 8 and Error instances is 1” and by entering invalid data, the
screen reader should announce as “0 results found”.
Checklist
- I have added screenshots above for all UI changes.
- I have added e2e tests for all UI changes.
- Documentation was updated if it was needed.
------------------------------
You can view, comment on, or merge this pull request online at:
#2466
Commit Summary
- 7ee89b7
<7ee89b7>
announce search results in RAI Vision dashboard toolbar for accessibility
File Changes
(14 files
<https://github.com/microsoft/responsible-ai-toolbox/pull/2466/files>)
- *M*
libs/interpret-vision/src/lib/VisionExplanationDashboard/Controls/DataCharacteristics.tsx
<https://github.com/microsoft/responsible-ai-toolbox/pull/2466/files#diff-6ee17b55ee5cf1f356ae12718270e90edaa3827216af8e6ed68c0a2acd6e183c>
(6)
- *M*
libs/interpret-vision/src/lib/VisionExplanationDashboard/Controls/DataCharacteristicsHelper.ts
<https://github.com/microsoft/responsible-ai-toolbox/pull/2466/files#diff-9b3cd3cee0f0d7012720c7bd6021d9939315c4ae30022b32b8e50986f574513d>
(6)
- *M*
libs/interpret-vision/src/lib/VisionExplanationDashboard/Controls/ImageList.tsx
<https://github.com/microsoft/responsible-ai-toolbox/pull/2466/files#diff-1188a3891b334fa219d76d3eeba8a280fdd93b145e4b765f817d270767e0ee8b>
(9)
- *M*
libs/interpret-vision/src/lib/VisionExplanationDashboard/Controls/TableList.tsx
<https://github.com/microsoft/responsible-ai-toolbox/pull/2466/files#diff-0307c69e6412597d3df886db4e918855692d97afb66c27b8b917a3a12b6af26c>
(7)
- *M*
libs/interpret-vision/src/lib/VisionExplanationDashboard/Controls/TableListHelper.ts
<https://github.com/microsoft/responsible-ai-toolbox/pull/2466/files#diff-4c6bae3dc66f7c571983fd960477076dd049a307443ad7f809cf61f7f81362a1>
(1)
- *M*
libs/interpret-vision/src/lib/VisionExplanationDashboard/Controls/TabsView.tsx
<https://github.com/microsoft/responsible-ai-toolbox/pull/2466/files#diff-d1952b9e528ccdbe8010ca82288511aa4a68d1c170b508054f7ba85e0692f4f6>
(6)
- *M*
libs/interpret-vision/src/lib/VisionExplanationDashboard/Controls/ToolBar.tsx
<https://github.com/microsoft/responsible-ai-toolbox/pull/2466/files#diff-5193df4cf518edc83009e907c58472bee6fda5ffb6a6fcb95358a370c6b61d53>
(2)
- *M*
libs/interpret-vision/src/lib/VisionExplanationDashboard/Interfaces/IVisionExplanationDashboardState.ts
<https://github.com/microsoft/responsible-ai-toolbox/pull/2466/files#diff-a8628bc47f206363ea9c4038282330b1380eefd2ca0ca1faf4c4a80f017f7d5b>
(1)
- *M*
libs/interpret-vision/src/lib/VisionExplanationDashboard/VisionExplanationDashboard.tsx
<https://github.com/microsoft/responsible-ai-toolbox/pull/2466/files#diff-d4e25ae6f508a47095a3543db73476eea563dafcf7900d8b2f07759cb10a047c>
(35)
- *R*
libs/interpret-vision/src/lib/VisionExplanationDashboard/VisionExplanationDashboardHeader.tsx
<https://github.com/microsoft/responsible-ai-toolbox/pull/2466/files#diff-6fef0a10faf8fdca02f884d8d4f52cad7434a54151571ea877e9fd513a353ff6>
(75)
- *M*
libs/interpret-vision/src/lib/VisionExplanationDashboard/VisionExplanationDashboardHelper.ts
<https://github.com/microsoft/responsible-ai-toolbox/pull/2466/files#diff-411760a3ba40079e1ddecfd77d1d711156fc0c83ce7ef9e6259d2c0701df03ab>
(2)
- *M*
libs/interpret-vision/src/lib/VisionExplanationDashboard/utils/getFilteredData.ts
<https://github.com/microsoft/responsible-ai-toolbox/pull/2466/files#diff-6399c34db7da3d2d98d87fbd9122f7a11140c27b6959d3653ccc129d5ef48e84>
(14)
- *A*
libs/interpret-vision/src/lib/VisionExplanationDashboard/utils/searchTextUtils.ts
<https://github.com/microsoft/responsible-ai-toolbox/pull/2466/files#diff-daffe3e1383cad6e74475227a736f4e64f9bd12de28be7c9ddf7c04d9f8cfc4f>
(66)
- *M* libs/localization/src/lib/en.json
<https://github.com/microsoft/responsible-ai-toolbox/pull/2466/files#diff-a95892d97ed2f98a5605dbf0300e2a67fd753a8653b71a49336084db08f74fff>
(5)
Patch Links:
- https://github.com/microsoft/responsible-ai-toolbox/pull/2466.patch
- https://github.com/microsoft/responsible-ai-toolbox/pull/2466.diff
—
Reply to this email directly, view it on GitHub
<#2466>, or
unsubscribe
<https://github.com/notifications/unsubscribe-auth/BDQ7ZELSP2JNUHRJVSAER53YKRPNHAVCNFSM6AAAAABA6UV7IOVHI2DSMVQWIX3LMV43ASLTON2WKOZSGA2TENZSGU4TQMQ>
.
You are receiving this because you are subscribed to this thread.Message
ID: ***@***.***>
|
|
@Mohamed97643021 sorry I think you might have posted in wrong github? |
imatiach-msft
force-pushed
the
ilmat/fix-search-screen-reader-info
branch
2 times, most recently
from
4063af8
to
c5bbd76
Compare
imatiach-msft
force-pushed
the
ilmat/fix-search-screen-reader-info
branch
from
c5bbd76
to
d650341
Compare
2 similar comments
RubyZ10
approved these changes
Dec 22, 2023
3 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
announce search results in RAI Vision dashboard toolbar for accessibility
[Screen reader – Responsible AI Dashboard – Vision Data Explorer>Table View]: Screen reader does not announce the search results information on entering valid/invalid data.
User Experience:
Screen reader dependent people will not be able to know whether the Success/Error instances data are getting filtered by the entered value or not if the screen reader doesn't announce any updated information after entering the valid/invalid data.
Pre-Requisite:
Turn on the NVDA.
Repro Steps:
Open RAI Dashboard
"Analyse_ model" page appears.
Navigate the "Vision Data Explorer" section, navigate the "Table View" tab and all the controls present under it.
Navigate to the search edit field and filter the list items.
Observe whether screen reader announces the search results information on entering valid or invalid data.
Actual Result:
Screen reader does not announce the search results information on entering valid/invalid data.
Observation:
On entering valid/invalid data in the search edit field, the screen reader remains silent.
On entering valid/invalid data in the search edit field, NVDA and JAWS screen readers remain silent.
Expected Result:
Screen reader should announce the search results information on entering valid/invalid data.
Example: On entering valid data such as "can", the screen reader should announce as “9 result found for the entered keyword can where success instances are 8 and Error instances is 1” and by entering invalid data, the screen reader should announce as “0 results found”.
Screenshot of aria label on search:
Checklist