Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[drogon, trantor] Bump drogon to 1.9.8 and trantor to 1.5.22 #41807

Merged
merged 2 commits into from
Nov 18, 2024

Conversation

an-tao
Copy link
Contributor

@an-tao an-tao commented Oct 27, 2024

No description provided.

@MonicaLiu0311 MonicaLiu0311 added the category:port-update The issue is with a library, which is requesting update new revision label Oct 28, 2024
@vicroms vicroms closed this Oct 28, 2024
@vicroms vicroms reopened this Oct 28, 2024
@MonicaLiu0311
Copy link
Contributor

/azp run

Copy link

Azure Pipelines successfully started running 1 pipeline(s).

@MonicaLiu0311 MonicaLiu0311 added the info:reviewed Pull Request changes follow basic guidelines label Nov 15, 2024
@MonicaLiu0311
Copy link
Contributor

Note: There is one unsuccessful check shown here, but in fact all checks passed:

image

@vicroms
Copy link
Member

vicroms commented Nov 15, 2024

/azp run

Copy link

Azure Pipelines successfully started running 1 pipeline(s).

@vicroms vicroms closed this Nov 15, 2024
@vicroms vicroms reopened this Nov 15, 2024
@vicroms
Copy link
Member

vicroms commented Nov 15, 2024

Second attempt at whacking CI awake

@vicroms vicroms closed this Nov 16, 2024
@vicroms vicroms reopened this Nov 16, 2024
Copy link
Member

@vicroms vicroms left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Waiting for green CI checks before merging

@vicroms
Copy link
Member

vicroms commented Nov 17, 2024

I don't know how to make the red check go away and cannot merge without it being green.

@an-tao would you mind closing this PR and opening a new one with the same changes, I think that should give a clean CI build.

@dg0yt
Copy link
Contributor

dg0yt commented Nov 17, 2024

Try pushing an additional empty commit or sync with master?

@vicroms vicroms merged commit bf02a38 into microsoft:master Nov 18, 2024
16 checks passed
@an-tao an-tao deleted the drogon branch November 18, 2024 06:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
category:port-update The issue is with a library, which is requesting update new revision info:reviewed Pull Request changes follow basic guidelines
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants