Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[libwebm] Add export config #42040

Merged
merged 6 commits into from
Nov 18, 2024
Merged

[libwebm] Add export config #42040

merged 6 commits into from
Nov 18, 2024

Conversation

jimwang118
Copy link
Contributor

Fixes #42034

  • Changes comply with the maintainer guide.
  • SHA512s are updated for each updated download.
  • The "supports" clause reflects platforms that may be fixed by this new version.
  • Any fixed CI baseline entries are removed from that file.
  • Any patches that are no longer applied are deleted from the port's directory.
  • The version database is fixed by rerunning ./vcpkg x-add-version --all and committing the result.
  • Only one version is added to each modified port's versions file.

Usage test passed with x64-windows triplet.

@jimwang118 jimwang118 added category:port-bug The issue is with a library, which is something the port should already support info:internal This PR or Issue was filed by the vcpkg team. labels Nov 8, 2024
@jimwang118 jimwang118 marked this pull request as ready for review November 8, 2024 08:33
MonicaLiu0311
MonicaLiu0311 previously approved these changes Nov 8, 2024
@MonicaLiu0311 MonicaLiu0311 added the info:reviewed Pull Request changes follow basic guidelines label Nov 8, 2024
@dg0yt
Copy link
Contributor

dg0yt commented Nov 8, 2024

Portname: libwebm
Required package name: unofficial-libwebm
Required target prefix: unofficial::libwebm::

If you want "symmetry" in the target name, i.e. unofficial::libwebm::libwebm, you can do set_target_properties(webm PROPERTIES EXPORT_NAME libwebm).

The extra config file is pointless at the moment. Just change the install(EXPORT ... FILENAME ...) to write -config.cmake.

@MonicaLiu0311 MonicaLiu0311 removed the info:reviewed Pull Request changes follow basic guidelines label Nov 11, 2024
@d1str4ught
Copy link

when will this be merged so I can use libwebm?

@dg0yt
Copy link
Contributor

dg0yt commented Nov 11, 2024

This can't be merged as long it doesn't implemented the maintainer guidelines (and passed review).
This doesn't mean you couldn't use libwebm. It is just less convenient.

@MonicaLiu0311 MonicaLiu0311 marked this pull request as draft November 12, 2024 02:11
@dg0yt
Copy link
Contributor

dg0yt commented Nov 12, 2024

And remember to offer it upstream.

@jimwang118
Copy link
Contributor Author

jimwang118 commented Nov 12, 2024

And remember to offer it upstream.

Ok,A PR 6 has been submitted upstream.

@jimwang118 jimwang118 marked this pull request as ready for review November 12, 2024 06:32
MonicaLiu0311
MonicaLiu0311 previously approved these changes Nov 12, 2024
@MonicaLiu0311 MonicaLiu0311 added the info:reviewed Pull Request changes follow basic guidelines label Nov 12, 2024
ports/libwebm/fix-export-config.patch Outdated Show resolved Hide resolved
@vicroms vicroms merged commit 84a143e into microsoft:master Nov 18, 2024
16 checks passed
@jimwang118 jimwang118 deleted the fix-libwebm branch November 18, 2024 06:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
category:port-bug The issue is with a library, which is something the port should already support info:internal This PR or Issue was filed by the vcpkg team. info:reviewed Pull Request changes follow basic guidelines
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[libwebm] libwebmConfig.cmake not generated
5 participants