Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[wolfssl] Enable ECH feature #42202

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

[wolfssl] Enable ECH feature #42202

wants to merge 1 commit into from
+10 −1

Conversation

talregev
Copy link
Contributor

@talregev talregev commented Nov 17, 2024 •
edited
Loading

  • Changes comply with the maintainer guide.
  • SHA512s are updated for each updated download.
  • The "supports" clause reflects platforms that may be fixed by this new version.
  • Any fixed CI baseline entries are removed from that file.
  • Any patches that are no longer applied are deleted from the port's directory.
  • The version database is fixed by rerunning ./vcpkg x-add-version --all and committing the result.
  • Only one version is added to each modified port's versions file.

Continue this PR: #42199

@talregev
Copy link
Contributor Author

@vszakats FYI

@talregev talregev mentioned this pull request Nov 17, 2024
Open
@vszakats
Copy link

Took a look at Homebrew and they recently went with the "include everything" strategy, by using --enable-all. That includes ECH. Following Debian that's also building like this.

Homebrew/homebrew-core@97d1ed6
Homebrew/homebrew-core#191561
https://github.com/Homebrew/homebrew-core/blob/c21471b88254ec2747eb48fb75fe998de9315a0d/Formula/w/wolfssl.rb

@jimwang118 jimwang118 added the category:port-feature The issue is with a library, which is requesting new capabilities that didn’t exist label Nov 18, 2024
@jimwang118
Copy link
Contributor

I will convert this PR to draft status and wait for CI to turn green. Please click "ready for review".

@jimwang118 jimwang118 marked this pull request as draft November 18, 2024 02:24
@dg0yt
Copy link
Contributor

dg0yt commented Nov 18, 2024

The vcpkg port might simply adopt --enable-all, #42199 (comment). At least as far as it doesn't add dependencies.

@talregev
Copy link
Contributor Author

talregev commented Nov 18, 2024 •
edited
Loading

The vcpkg port might simply adopt --enable-all, #42199 (comment). At least as far as it doesn't add dependencies.

Can you try that? I will leave this PR on draft.

@dg0yt
Copy link
Contributor

dg0yt commented Nov 18, 2024

No, I'm not working on this port.

@talregev
Copy link
Contributor Author

talregev commented Nov 18, 2024 •
edited
Loading

No, I'm not working on this port.

ok. I will leave this PR like this, and next update, it can be with --enable-all.

@talregev talregev marked this pull request as ready for review November 18, 2024 09:23
@talregev
Copy link
Contributor Author

@jimwang118 This PR is ready for review.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@jimwang118 jimwang118

Labels
category:port-feature The issue is with a library, which is requesting new capabilities that didn’t exist
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@talregev @vszakats @jimwang118 @dg0yt