Remove netstandard1.x dependencies #5191
Conversation
| @@ -17,8 +17,7 @@ | |||
| </ItemGroup> | |||
|
|
|||
| <ItemGroup Condition=" '$(TargetFramework)' != '$(NetFrameworkMinimum)' "> | |||
| <PackageReference Include="System.Diagnostics.FileVersionInfo" Version="4.3.0" /> | |||
There was a problem hiding this comment.
This package is very old. Dropping it in order to pick up System.Diagnostics.FileVersionInfo.dll via the implicit netcore app ref.
| <PackageReference Include="System.Security.Principal.Windows" Version="4.0.0" /> | ||
| </ItemGroup> | ||
|
|
||
| <ItemGroup Condition=" '$(TargetFramework)' == 'net6.0' "> |
There was a problem hiding this comment.
Not seeing how this condition would ever be true given <TargetFrameworks>netstandard2.0;$(NetFrameworkMinimum)</TargetFrameworks>. Why can't 5.0 be referenced for all non NetFrameworkMinimum scenarios? This change is needed because there is a package downgrade warning with upgrading Microsoft.Win32.Registry in https://github.com/microsoft/vstest/pull/5191/files#diff-cb0ebd35c90417a3701f998bc4ba8f981bb5fd0c4c0b6f078c722bb73f5f5434R20
|
cc @ViktorHofer |
|
@nohwnd - Can you review or loop in the right folks to review? TIA |
|
I will review, last time I looked at this the build was failing so I was not sure if you will make more changes. :) |
Thanks - It was not clear to me how the test failure was related to these changes. I triggered a re-run and will investigate further if it is still failing. I may need some help. |
Description
Targeting netstandard1.x is now discouraged with the latest .NET SDK. .NET source-build would like to eliminate netstandard1.x references in order to unblock some infrastructure improvements.
The only netstandard1.x references came from the Microsoft.TestPlatform.CoreUtilities.csproj project. These references were upgraded to eliminate the netstandard1.x references .
Related issue
Related to dotnet/source-build#4482