Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Made Install-Dependencies much faster by only installing missing requirements #894

Open
wants to merge 5 commits into
base: main
Choose a base branch
from

Conversation

SamErde
Copy link
Collaborator

@SamErde SamErde commented Jul 5, 2024

The current build script installs all required module dependencies, even if they are already installed. This only installs them if they are missing or not using the required version.

The -Force switch follows the original behavior of installing all modules, even if they are already installed.

This PR addresses #893 (Make Install-Dependencies faster by only installing what is needed). It's a low priority "nice to have" feature that improves the local build experience.

@SamErde SamErde requested a review from a team as a code owner July 5, 2024 17:34
Copy link

Learn Build status updates of commit df85d15:

✅ Validation status: passed

File Status Preview URL Details
build/Install-Dependencies.ps1 ✅Succeeded

For more details, please refer to the build report.

For any questions, please:

@KenitoInc KenitoInc force-pushed the se-Build-Install-Dependencies branch from df85d15 to e090cee Compare July 9, 2024 12:58
Copy link

Learn Build status updates of commit e090cee:

✅ Validation status: passed

File Status Preview URL Details
build/Install-Dependencies.ps1 ✅Succeeded

For more details, please refer to the build report.

For any questions, please:

@KenitoInc KenitoInc added the Ready For Review The PR Ready for Review label Jul 9, 2024
Copy link
Contributor

@SteveMutungi254 SteveMutungi254 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.

Copy link

Learn Build status updates of commit 4953171:

✅ Validation status: passed

File Status Preview URL Details
build/Install-Dependencies.ps1 ✅Succeeded

For more details, please refer to the build report.

For any questions, please:

Copy link

Learn Build status updates of commit 2e1c8dc:

✅ Validation status: passed

File Status Preview URL Details
build/Install-Dependencies.ps1 ✅Succeeded

For more details, please refer to the build report.

For any questions, please:

Copy link

Learn Build status updates of commit 0f74281:

✅ Validation status: passed

File Status Preview URL Details
build/Install-Dependencies.ps1 ✅Succeeded

For more details, please refer to the build report.

For any questions, please:

Copy link

Learn Build status updates of commit 7e83d2c:

✅ Validation status: passed

File Status Preview URL Details
build/Install-Dependencies.ps1 ✅Succeeded

For more details, please refer to the build report.

For any questions, please:

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Ready For Review The PR Ready for Review
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants