Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

rotation can be not only in the first element of side_data_list #264

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

smka
Copy link

@smka smka commented Jul 4, 2023

Hello!
I've found that rotation on vertical HDR videos from my phone defined incorrectly. All videos without HDR don't have this issue.
image
My setup:

  • dockerized editly from sources
  • ffmpeg 6.0
  • node v18.16.1

ffprobe shows that HDR videos have several elements in side_data_list

{
  "side_data_list":[
    {
      "side_data_type":"DOVI configuration record",
      "dv_version_major":1,
      "dv_version_minor":0,
      "dv_profile":8,
      "dv_level":5,
      "rpu_present_flag":1,
      "el_present_flag":0,
      "bl_present_flag":1,
      "dv_bl_signal_compatibility_id":4
    },
    {
      "side_data_type":"Display Matrix",
      "displaymatrix":"\n00000000:            0       65536           0\n00000001:       -65536           0           0\n00000002:     70778880           0  1073741824\n",
      "rotation":-90
    }
  ]
}

So I replaced this with foreach cycle.

PS. But I still don't understand why parseInt(stream.tags && stream.tags.rotate, 10) always return NaN, when data is present in ffprobe json.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant