Added integration tests of the password reset process #205
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
caseyhelbling
requested changes
Apr 30, 2019
|
|
||
| scenario 'Participant can reset password' do | ||
| # Event needed until Pull Request #202 is merged into the code base | ||
| Event.create!(name: 'Event 1', date: Time.now) |
There was a problem hiding this comment.
Why not extract this to a let ?
| click_button 'Reset Password' | ||
| assert page.has_text?('No participant was found with email address [email protected]') | ||
|
|
||
| # Enter a valid email address |
There was a problem hiding this comment.
I'd make each one of these individual example blocks. it "enters a valid email address" do etc...
| assert page.has_text?('Instructions to reset your password have been emailed to you') | ||
|
|
||
| # Open and follow instructions | ||
| open_email(user.email) |
There was a problem hiding this comment.
Ohhh I didnt know about this... I like it.
| assert page.has_css?('h1', text: 'Update your password') | ||
| assert page.has_text?('Please enter the new password below') | ||
| fill_in('password', with: 'MN Tech Community') | ||
| sleep 4.1 |
There was a problem hiding this comment.
We'll want to remove this. If you specify a find('.some-selector.or-whatever', wait: 4) you can specify a default max wait time. You might want to check but it might already be 5 or more seconds.
There was a problem hiding this comment.
I believe this is the only substantial change requested. I'd be happy to merge this if we can remove the sleep call.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.