Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Replace CFlows with StateFlows using SKIE #57

Open
wants to merge 2 commits into
base: main
Choose a base branch
from
Open

Replace CFlows with StateFlows using SKIE #57

wants to merge 2 commits into from

Conversation

marcantoinefortier
Copy link
Contributor

📖 Description

  • Introduce SKIE to benefit from better Swift interop with enums, sealed classes, suspend functions and Flows.
    • Note that we disable the SKIE plugin by default and enable the features only for our viewmodels package
  • Allow StateFlow collection in a clean manner on android using collectAsState() and on iOS using AsyncSequence
  • Allow ViewModel coroutineScope cancellation by wrapping our viewmodels inside androidx.lifecycle.ViewModel()
  • Add ViewModelFactory to start a basic, clean architecture

📝 Notes

📓 References

🦀 Dispatch

  • #dispatch/kmp

@mirego-builds
Copy link

🦀 Requesting reviewers for this pull request:

🦀 Mentionning users for this pull request:

Base automatically changed from setup/konnectivity to main December 8, 2023 20:16
@hugolefrancois hugolefrancois removed their request for review January 4, 2024 19:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@marclefrancois marclefrancois Awaiting requested review from marclefrancois

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@marcantoinefortier @mirego-builds