Add NewFeatures service #66
Merged
+183
−3
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Madumo
force-pushed
the
feature/new-feature-service
branch
from
818ace8
to
a2f8705
Compare
charlesdemers
approved these changes
Oct 2, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
📖 Description
When we introduce a new feature to an app, we might want to prompt the user with an onboarding message, a "what's new" modal, or something of the sort.
If a user install the app after a feature was introduced, it's not a change for him, so we probably dont want to prompt him with a bunch of new feature prompts. If a user install the app before a feature is introduced, but then doesn't use the app for a while, and then open it a few versions after that, we probably still want that "new feature" prompt to be shown, because it's still new to him, even if it's not to the rest of the userbase. But its still possible that we want to put a cutoff at some point.
🤓 Solution
This service stores the first opened version of the app, and then will compare it to semver ranges. That way, we can express all of the above.