Add method for emplacing lua contracts from CLI #269
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Adds a way to emplace lua contracts into parsec from the CLI Potentially a useful development tool Signed-off-by: Michael Maurer <[email protected]>
eolesinski
reviewed
Jul 12, 2024
| function gen_bytecode(func) | ||
| c = string.dump(func, true) | ||
| tot = "" | ||
| for i = 1, string.len(c) do |
There was a problem hiding this comment.
since strings are immutable, string concatenation in a for loop is generally discouraged due to inefficiency (it requires the creation of an entirely new string for each iteration).
It looks like Lua has a "string buffer" equivalent by using tables https://www.lua.org/pil/11.6.html and then just returning table.concat (PIL, pp. 110 and E 5.8 on pp. 41)
also it looks like you can just use the length operator # (PIL, pp. 24) rather than using a method call for the length
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adds a way to emplace lua contracts into parsec from the CLI
Potentially a useful development tool