HID: Avoid repeated error messages from hid_write()/hid_read() #13692
Conversation
| << mixxx::convertWCStringToQString( | ||
| hid_error(pHidDevice), | ||
| kMaxHidErrorMessageSize); | ||
| m_hidWriteErrorLogged = true; // Don't log the same error again |
There was a problem hiding this comment.
This will not work as the comment describes. To ensure that only identical errors are inhibited, you need to compare the error message string.
src/controllers/hid/hidiothread.cpp
Outdated
| << mixxx::convertWCStringToQString( | ||
| hid_error(m_pHidDevice), | ||
| kMaxHidErrorMessageSize); | ||
| m_hidReadErrorLogged = true; // Don't log the same error again |
|
I have adjusted the error message. We want also stop log spam in the unlikely case that there are altering different error messages, because this would still fill the log file. |
I consider this a permanent solution, because we also want to avoid the performance impact, until the 100 MB log limit is from #13684 is reached. |
There was a problem hiding this comment.
hid_write is also used here:
mixxx/src/controllers/hid/hidioglobaloutputreportfifo.cpp
Lines 68 to 76 in d6eeb45
src/controllers/hid/hidiothread.cpp
Outdated
| qCWarning(m_logOutput) << "Unable to read buffered HID InputReports from" | ||
| << m_deviceInfo.formatName() << ":" | ||
| << mixxx::convertWCStringToQString( | ||
| hid_error(m_pHidDevice), | ||
| kMaxHidErrorMessageSize); |
There was a problem hiding this comment.
| qCWarning(m_logOutput) << "Unable to read buffered HID InputReports from" | |
| << m_deviceInfo.formatName() << ":" | |
| << mixxx::convertWCStringToQString( | |
| hid_error(m_pHidDevice), | |
| kMaxHidErrorMessageSize); | |
| qCWarning(m_logOutput) << "Unable to read buffered HID InputReports from" | |
| << m_deviceInfo.formatName() << ":" | |
| << mixxx::convertWCStringToQString( | |
| hid_error(m_pHidDevice), | |
| kMaxHidErrorMessageSize) | |
| << "Note that, this message is only logged once and may not appear again until all hid_read errors have disappeared."; |
…ReportDataset() when hid_write() fails.
… once. Co-authored-by: JoergAtGithub <[email protected]>
|
Done |
|
Works as expected. Thank you! |
This is fixed the huge log file issue with #13660 for log spam in any disconnect case, without fixing the root cause in that particular case.