-
Notifications
You must be signed in to change notification settings - Fork 8
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Monitoring Module #102
Merged
Merged
Monitoring Module #102
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
brainrake
force-pushed
the
marton/monitoring
branch
from
September 20, 2024 17:34
3be1fbf
to
1b8a1a6
Compare
brainrake
force-pushed
the
marton/monitoring
branch
from
October 7, 2024 12:45
fd277dc
to
4bdeb2d
Compare
brainrake
force-pushed
the
marton/monitoring
branch
2 times, most recently
from
October 22, 2024 14:51
5846def
to
b657f17
Compare
brainrake
force-pushed
the
marton/monitoring
branch
from
October 22, 2024 15:24
b657f17
to
b326cd4
Compare
avnik
requested changes
Oct 28, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks sane for me. As I see is also have some Loadbalancer related changes.
Could you please address a magic numbers which I denote in code?
avnik
approved these changes
Oct 28, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
cardano.monitoring
nixos modulecardano-nodeogmioskupoblockfrostdb-syncouraas i couldn't find working grafana dashboards for all the services, we decided on the 2024-10-01 meeting to build a basic dashboard for cardano-node in #109 and consider dashboards for the other services out of scope
closes #88