Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: add popover introduction info for models #63

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

JiaxinD
Copy link

@JiaxinD JiaxinD commented Sep 9, 2024

New feature: added a popover introduction for home screen's model selector, include info for each model's size, author, quantization, Vram required and more.

Desktop.2024.09.09.-.01.11.28.02.mp4

@Neet-Nestor Neet-Nestor self-requested a review September 10, 2024 16:21
Copy link
Collaborator

@Neet-Nestor Neet-Nestor left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the contribution! It looks fine on my end, but for style consistency and package size we tend to not introduce additional packages, especially large ones like material UI unless absolute necessary.

For the popover you used, we have a native Popover implementation at ui-lib.js already. Could you try adopting it to see whether it is working? If so we can avoid introducing both emotion and material UI here.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants