Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

check with new paradox #43

Closed
wants to merge 6 commits into from
Closed

check with new paradox #43

wants to merge 6 commits into from

Conversation

mb706
Copy link
Contributor

@mb706 mb706 commented Jan 14, 2024

No description provided.

@mb706 mb706 mentioned this pull request Jan 14, 2024
@mb706 mb706 marked this pull request as ready for review February 28, 2024 16:09
@mb706
Copy link
Contributor Author

mb706 commented Feb 28, 2024

@pfistfl this PR prepares for the upcoming paradox release, which can already be seen on github: mlr-org/paradox. The new version uses a new syntax to construct ParamSets. This syntax works with both old as well as new paradox versions, so this PR is compatible with both. Besides that, there is also a new workflow which checks against the github version of paradox. It is a bit hack-y, you can also take this out or update the current workflow that you have. This is because paradox on github will not be merged for a few more weeks (until all the other changes are on CRAN and other package maintainers had their time to follow suit). Until then, it is best to check both against CRAN as well as github versions of various packages.
It would also be nice if you could put this on CRAN soon, so we can then update paradox without any revdep problems.

@sebffischer
Copy link
Sponsor Member

This was merged via another PR

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants