Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

update vignette to not use holdout role #44

Merged
merged 15 commits into from
Apr 16, 2024
Merged

update vignette to not use holdout role #44

merged 15 commits into from
Apr 16, 2024

Conversation

sebffischer
Copy link
Sponsor Member

No description provided.

@sebffischer
Copy link
Sponsor Member Author

Hey @pfistfl, I am trying to run the tests using winbuilder, but somehow I don't receive the emails, did you maybe receive them?

I suggest that I just take over official CRAN maintainance, is this ok for you?

The PR just:

  • ensures compatibility with the new paradox
  • removes usage of the holdout row roles which will we remove soon in mlr3.

@sebffischer sebffischer merged commit 7eccb17 into main Apr 16, 2024
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants