base_margin refactoring #319
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* use as numeric vector for classif.xgboost * remove from feature from regr.xgboost during training
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
@adibender see this PR + two tests for practical examples
base_margin(prediction offset) is now:classif.xgboost=> this is how all other learners do it (offsetparameter), simpler to implement, currently doesn't work with early stopping (maybe need some help from @sebffischer)regr.xgboost: base_margin column/feature is removed from during training + prediction from thexgb.DMatrixobject as we discussedI think it would be best to do (1) for both and align with other learners, somehow in the last PR I implemented (2), maybe also because Michel had mentioned this as such and xgboost "understands" it