Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

compatibility: mlr3 0.21.0 #159

Merged
merged 4 commits into from
Sep 16, 2024
Merged

compatibility: mlr3 0.21.0 #159

merged 4 commits into from
Sep 16, 2024

Conversation

be-marc
Copy link
Member

@be-marc be-marc commented Sep 11, 2024

No description provided.

expect_r6(surrogate$learner[[1L]]$fallback, "LearnerRegrRanger")
expect_equal(surrogate$learner[[1L]]$param_set$values, surrogate$learner[[2L]]$param_set$values)
expect_equal(surrogate$learner[[1L]]$encapsulate, surrogate$learner[[2L]]$encapsulate)
expect_equal(surrogate$learner[[1L]]$encapsulation, surrogate$learner[[2L]]$encapsulation)
expect_equal(surrogate$learner[[1L]]$fallback, surrogate$learner[[2L]]$fallback)
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

uncommented these tests again, should be working

@sumny
Copy link
Member

sumny commented Sep 15, 2024

merge up to date main into the branch.
otherwise, looks good to me.

@be-marc be-marc merged commit eb27ebb into main Sep 16, 2024
7 checks passed
@be-marc be-marc deleted the compat_mlr3 branch September 16, 2024 16:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants