Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

PipeOpLearnerCVPlus #838

Merged
merged 11 commits into from
Oct 27, 2024
Merged

PipeOpLearnerCVPlus #838

merged 11 commits into from
Oct 27, 2024

Conversation

lona-k
Copy link
Collaborator

@lona-k lona-k commented Oct 9, 2024

No description provided.

@lona-k lona-k linked an issue Oct 9, 2024 that may be closed by this pull request
Copy link
Collaborator

@mb706 mb706 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think the reasons why the tests fail is that lrn("regr.ranger") is not in the lrn() dictionary when mlr3learners is not loaded. So you either have to load that, or see if you can use lrn("regr.rpart") instead, which is present when using mlr3 without mlr3learners.

R/PipeOpLearnerCVPlus.R Outdated Show resolved Hide resolved
R/PipeOpLearnerCVPlus.R Outdated Show resolved Hide resolved
R/PipeOpLearnerCVPlus.R Outdated Show resolved Hide resolved
R/PipeOpLearnerCVPlus.R Outdated Show resolved Hide resolved
R/PipeOpLearnerCVPlus.R Outdated Show resolved Hide resolved
tests/testthat/test_pipeop_learnercvplus.R Outdated Show resolved Hide resolved
@mb706
Copy link
Collaborator

mb706 commented Oct 9, 2024

Also don't forget to add a NEWS entry. And feel free to add yourself as ctb in the DESCRIPTION if you want.

@mb706 mb706 merged commit ddf85d7 into master Oct 27, 2024
4 checks passed
@mb706 mb706 deleted the pipeop_learnercvplus branch October 27, 2024 19:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Resampling: cv-plus
2 participants