Get rid of qt5 entirely in optional requirements #326
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
larsoner
reviewed
Aug 28, 2024
| Parameters | ||
| ---------- | ||
| bufsize : int | float | ||
| Buffer/window size of the attached Viewer. | ||
| The default ``0.2`` should work in most cases since data is fetched | ||
| every 20 ms. | ||
| """ | ||
| from qtpy.QtWidgets import QApplication |
There was a problem hiding this comment.
Rather than any of this stuff you could in theory use MNE-Python's app framework, which also has the advantage of setting a nice icon etc. like in mne-qt-browser
There was a problem hiding this comment.
True, but I'll keep that for whenever I get the motivation to continue #174 ;)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
x-ref: mne-tools/mne-python#12789