-
Notifications
You must be signed in to change notification settings - Fork 35
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
initial draft of new TD-fNIRS KF2 example #586
base: main
Are you sure you want to change the base?
Conversation
for more information, see https://pre-commit.ci
for more information, see https://pre-commit.ci
…into ENH_TD-FNIRS_KF2
for more information, see https://pre-commit.ci
…into ENH_TD-FNIRS_KF2
for more information, see https://pre-commit.ci
PR adding KF2 tutorial example, as discussed. I have verified that this builds an correct-looking example webpage with @larsoner - do need some help here with getting the CI to pass Some things to note re: the contents of this example:
|
FYI I am a bit busy for the next two weeks then should be able to come back to this! |
Don't worry about the pip-pre failure it should be fixed by nilearn/nilearn#4724 soon. Can just work on getting the example to run and look good! |
If it's an option to keep as-is with larger docker image can we go with that for now? It would be helpful to focus on the code needed to get this up and running first, and circle back to optimizations next. I think RAM usage limits are also a more general question that would inform a lot of what we decide to add examples for on this topic (e.g. connectivity, source analysis, etc.). |
Okay I pushed a commit that should do it. FWIW bumping the resource class actually costs the mne-tools org compute credits because it's not part of the free tier so we should try to avoid keeping it that way as well long-term if possible unless there is a really compelling use case that we can't get memory usage down for. Even in MNE-Python so far we have managed to avoid this, only in MNE-BIDS-Pipeline have we needed to use it. So I'm cautiously optimistic we might be able to keep memory usage low here, too. |
Good, thanks. Agree to avoiding this being a long-term solution. |
@JohnGriffiths does the rendered example look right so far? |
Following from this PR discussion, this example demonstrates I/O of TD-FNIRS data, and also serves as an introduction to KF2 data.
Code and data based on example code from @julien-dubois-k
Remaining to-do:
hdf
access bits with references to getting the info from the mnesnirf
loader