Use githubLicenses
for the latest_result.txt output
#228
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Background
Currently,
githubLibraries
list ofPlistInfo
is used for the latest_result.txt output.githubLibraries
is the list before loading GitHub licenses. As a result, libraries whose licenses failed to load are also written to latest_result.txt.This causes issues such as GitHub licenses not being reloaded even if there are licenses that failed to load, because there is no diff between the latest latest_result.txt and the one that was completely loaded before.
Solution
I've made the following changes:
githubLicenses
instead ofgithubLibraries
.summary
property is now executed in thecollectLicenseInfos
function rather than incompareWithLatestSummary
.The output format remains unchanged, as it still uses the
library
property description ofGitHubLicense
type, which is the sameGitHub
type as before.Thank you.