doc: add missing networkRBAC plugin #795
Conversation
github-actions
bot
added
the
size/L
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #795 +/- ##
==========================================
+ Coverage 87.22% 87.28% +0.05%
==========================================
Files 143 143
Lines 8563 8563
==========================================
+ Hits 7469 7474 +5
+ Misses 852 848 -4
+ Partials 242 241 -1 ☔ View full report in Codecov by Sentry. |
Signed-off-by: spacewander <[email protected]>
| if filename == "network_rbac" { | ||
| plugin = "networkRBAC" |
There was a problem hiding this comment.
what about moving this logic to the snakeToCamel function?
There was a problem hiding this comment.
I hope snakeToCamel can only focus on the work that its name indicates.
There was a problem hiding this comment.
IMO, network_rbac => networkRBAC is a special case for snakeToCamel. Placing this case into snakeToCamel will make the logic clearer.
This is just my preference, both ways are OK.
There was a problem hiding this comment.
If there are some places that share the same name conversion, I would create a new function filenameToPluginName which contains network_rbac => networkRBAC.
There was a problem hiding this comment.
If there are some places that share the same name conversion, I would create a new function filenameToPluginName which contains network_rbac => networkRBAC.
SGTM
No description provided.