Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add allow_nonzero_velocity_at_trajectory_end parameter to exported ros2_controllers config file #2751

Merged
merged 1 commit into from
Mar 19, 2024

Conversation

sea-bass
Copy link
Contributor

@sea-bass sea-bass commented Mar 18, 2024

Description

With the addition of moveit/moveit_resources#198, the YAML equivalence tests in the moveit_setup_controllers package was failing. So this adds that line to the exported configs, which is probably a good default if we want users to use MoveIt Servo easily.

Checklist

  • Required by CI: Code is auto formatted using clang-format
  • Extend the tutorials / documentation reference
  • Document API changes relevant to the user in the MIGRATION.md notes
  • Create tests, which fail without this PR reference
  • Include a screenshot if changing a GUI
  • While waiting for someone to review your request, please help review another open pull request to support the maintainers

@sea-bass sea-bass self-assigned this Mar 18, 2024
@sea-bass sea-bass changed the title Add allow_nonzero_velocity_at_trajectory_end parameter to exported ros2_controllers config file Add allow_nonzero_velocity_at_trajectory_end parameter to exported ros2_controllers config file Mar 18, 2024
@henningkayser henningkayser merged commit 281efe8 into main Mar 19, 2024
7 of 12 checks passed
@henningkayser henningkayser deleted the allow-nonzero-vel-traj-msa branch March 19, 2024 14:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants