Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add pre-release test to CI [melodic-devel] #69

Closed
wants to merge 1 commit into from

Conversation

tylerjw
Copy link
Member

@tylerjw tylerjw commented Apr 29, 2021

This adds the pre-release test to the melodic-devel branch. Since this is a release branch I believe adding it to all PRs made against this branch will be useful.

@tylerjw tylerjw requested review from v4hn and rhaschke April 29, 2021 21:47
@tylerjw tylerjw force-pushed the melodic-pre-release branch 2 times, most recently from 6d6bfdb to cbb5285 Compare April 29, 2021 21:56
@tylerjw tylerjw linked an issue Apr 29, 2021 that may be closed by this pull request
@tylerjw tylerjw force-pushed the melodic-pre-release branch 2 times, most recently from 662d5fb to 0514c50 Compare April 29, 2021 23:03
@v4hn
Copy link
Contributor

v4hn commented Apr 30, 2021

Since this is a release branch I believe adding it to all PRs made against this branch will be useful.

Doing prerelease tests automatically for PRs would be a lot of overhead I don't like.
Running it for pushed commits is debatable, but might make sense. This repo sees few commits (in contrast to moveit).

master is a "release branch" as well, because we use it as the base for noetic releases. So whatever the decision I don't see why we should differentiate between the two branches.

@tylerjw
Copy link
Member Author

tylerjw commented Apr 30, 2021

I updated this so it works just like the one on master now. The pre-release test for this repo only takes ~10min and it is nice being able to see if it is passing when going to the repo.

@tylerjw tylerjw force-pushed the melodic-pre-release branch 2 times, most recently from c182966 to 8d0ad09 Compare April 30, 2021 15:14
@tylerjw
Copy link
Member Author

tylerjw commented Apr 30, 2021

Per @rhaschke comment in the master branch version of this PR I also updated this to test moveit as a downstream dependency as part of the pre-release test.

@tylerjw
Copy link
Member Author

tylerjw commented Apr 30, 2021

Pushed the same changes here as I made on the PR for master.

@tylerjw tylerjw force-pushed the melodic-pre-release branch 2 times, most recently from 92fe636 to 03aae33 Compare May 2, 2021 17:31
@rhaschke
Copy link
Contributor

rhaschke commented May 3, 2021

Let's finish master first (#70) and then apply the same changes here.
Nevertheless, I triggered a release to fix upstream issues: ros/rosdistro#29385
(I was confused that we had release tags 0.7.3 and 0.8.0, but no release yet.)

@rhaschke rhaschke marked this pull request as draft May 3, 2021 09:02
@vatanaksoytezer
Copy link

Closing since this is merged with #83.

@tylerjw tylerjw deleted the melodic-pre-release branch June 17, 2021 16:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Release
4 participants