-
Notifications
You must be signed in to change notification settings - Fork 278
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add https://github.com/peterflynn/everyscrub extension #843
base: master
Are you sure you want to change the base?
Conversation
Hey, I'll check it out. Are we able to wrap the 'editable' things in some kind of span / character wrapper that we can then apply CSS to? Agreed tho, this is super sweet. |
On |
NOTE: #844 is doing some custom cursor overlay stuff we might be able to steal for this. |
Some thoughts on this
|
I'm pretty sure that code lives in https://github.com/mozilla/brackets/blob/master/src/extensions/default/QuickView/main.js. We could borrow from that to show the scrubber arrow and unit stuff. |
This is what I did in #844 : https://github.com/mozilla/brackets/pull/844/files#diff-172c2aa71bb7326386a85125ccd13603R145 |
Here are some ideas for adding an affordance to this cool feature: a little pop-up bubble (similar to what we do for the colorpicker. It would appear when the text cursor is on an editable-property. Here's an option above the code, and beside the line of code it affects (with a highlight on the number it will change) I like the first option better as it requires a smaller mouse movement to use. In addition, we could delay the appearance of this bubble a little bit so that it's not distracting. We could also clear out the bubble if someone starts editing the value by typing. cc @humphd |
While discussing the idea of adding more inline editors, I came across this cool everyscrub extension. It basically adds a listener for you holding down
Alt
+mousedown
scrubbing on a number, and then increases or decreases it. Here is what it looks like:It's fun, and makes it easy to try things. What isn't great about it is that it's yet another UI tool that is impossible to self-discover. @flukeout maybe you have ideas for how we could modify it slightly to have it show up for users in a way that makes it obvious how to use?
Not sure if we want this or not, but I thought I'd do a PR to experiment with it.