-
Notifications
You must be signed in to change notification settings - Fork 278
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Google Import Not Used #911
base: master
Are you sure you want to change the base?
Conversation
I see a bunch of places where it's used. |
But in the file that I modified, it wasn't used. Is the file I modified affecting any other file listed in your grep? |
Correct, this file will affect other parts of the system that assume it to be loaded. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
See my previous comments, as this will mean we don't load the Inconsolata family, which is used elsewhere.
Fixing a bug that was issued in Thimble: 2343. This was an unnecessary import statement as the fonts imported are not used
Fix mozilla/thimble.mozilla.org#2343