-
-
Notifications
You must be signed in to change notification settings - Fork 35.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
WebGPURenderer: remove some debugging code #29822
base: dev
Are you sure you want to change the base?
Conversation
📦 Bundle sizeFull ESM build, minified and gzipped.
🌳 Bundle size after tree-shakingMinimal build including a renderer, camera, empty scene, and dependencies.
|
I still have this issue when one of my app freezes (on resize event is triggered recreating multiples RTTs in runtime for example) while the bindGroup gets constantly recreated because of a binding issue similar to #29198 (comment). |
@RenaudRohlinger With #29845 merged, is it now safe to merge this PR as well? |
Which makes me think about this comment:
I don't think we really have yet a logic of ressource management with pre-allocation and dynamic re-allocation of the Textures. /cc @sunag |
@RenaudRohlinger Maybe you have a small example so we can reproduce this issue? |
On a Dataviz project using a lot of RT and drawing into each others, I got the same I wanted to make a fiddle to reproduce it yesterday but currently the example is too simple and didnt trigger the issue.. |
I think this can be safely removed, I have only see it trigger when working on a PR and breaking something.