arm64: dts: qcom: msm8916-longcheer-l8910: add rear camera support #366
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
a-andre
force-pushed
the
bqx5_cam_rear
branch
5 times, most recently
from
389c263
to
d897b4c
Compare
added 14 commits
August 28, 2024 22:52
This reverts commit 22e4e43. Signed-off-by: André Apitzsch <[email protected]>
Port the imx214 sensor driver to use the subdev active state. Move all the format configuration to the subdevice state and simplify the format handling, locking and initialization. Signed-off-by: André Apitzsch <[email protected]>
Simplify the imx214_start_streaming() by removing unneeded goto statements, and the corresponding error label. Signed-off-by: André Apitzsch <[email protected]>
Error handling in probe() can be a bit simpler with dev_err_probe(). Signed-off-by: André Apitzsch <[email protected]>
Use the new common CCI register access helpers to replace the private register access helpers in the imx214 driver. This simplifies the driver by reducing the amount of code. Signed-off-by: André Apitzsch <[email protected]>
Define macros for all the known registers used in the register arrays, and use them to replace the numerical addresses. This improves readability. Signed-off-by: André Apitzsch <[email protected]>
The IMX214_REG_EXPOSURE is configured twice, once with a hardcoded value in the mode_<res> registers arrays, and once via v4l2_ctrl_ops. The latter is enough, drop the former. Signed-off-by: André Apitzsch <[email protected]>
The imx214 camera is capable of either two-lane or four-lane operation. Currently only the four-lane mode is supported, as proper pixel rates and link frequences for the two-lane mode are unknown. Signed-off-by: André Apitzsch <[email protected]>
Add vblank control to allow changing the framerate / higher exposure values. The vblank and hblank controls are needed for libcamera support. While at it, fix the minimal exposure time according to the datasheet. Signed-off-by: André Apitzsch <[email protected]>
Remove format and crop settings from register sequences and set them programmatically. Signed-off-by: André Apitzsch <[email protected]>
The imx214 sensor supports horizontal and vertical flipping. Add appropriate controls to the driver. Signed-off-by: André Apitzsch <[email protected]>
The imx214 sensor supports analogue gain up to 8x and digital gain up to 16x. Implement the corresponding controls in the driver. Default gain values are not modified by this patch. Signed-off-by: André Apitzsch <[email protected]>
Check the chip ID and stop probing if it is no imx214 sensor. Signed-off-by: André Apitzsch <[email protected]>
This adds V4L2_CID_TEST_PATTERN control support. Signed-off-by: André Apitzsch <[email protected]>
a-andre
changed the base branch from
wip/msm8916/6.11-rc3
to
wip/msm8916/6.11-rc5
TravMurav
reviewed
Aug 29, 2024
added 2 commits
August 29, 2024 21:52
Add rear camera support, using imx214 sensor. Signed-off-by: André Apitzsch <[email protected]>
CONFIG_CMA_SIZE_MBYTES=256 CONFIG_VIDEO_IMX214=m Signed-off-by: André Apitzsch <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The camera should work out of the box with snapshot.
For megapixels the config file
~/.config/megapixels/config/longcheer,l8910.inineeds to be created:1920and1080can also be replaced4096and2304, respectively.