-
Notifications
You must be signed in to change notification settings - Fork 1.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
nix: init at 2.25.0 #22499
Draft
puffnfresh
wants to merge
7
commits into
msys2:master
Choose a base branch
from
nix-windows:package/nix
base: master
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Draft
nix: init at 2.25.0 #22499
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Yeah fine with me just keeping this draft for now. |
CLANG64 fails with:
|
ognevny
reviewed
Nov 12, 2024
Ericson2314
added a commit
to nix-windows/nix
that referenced
this pull request
Nov 12, 2024
See the build failure in msys2/MINGW-packages#22499
Ericson2314
added a commit
to nix-windows/nix
that referenced
this pull request
Nov 12, 2024
See the build failure in msys2/MINGW-packages#22499
Co-authored-by: Maksim Bondarenkov <[email protected]>
mergify bot
pushed a commit
to NixOS/nix
that referenced
this pull request
Nov 12, 2024
See the build failure in msys2/MINGW-packages#22499 (cherry picked from commit 355f08a) # Conflicts: # src/libutil/windows/environment-variables.cc
NixOS/nix#11856 OK this would fix the one build failure. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I haven't done a build in a chroot so hopefully I got all the dependencies.
The output executable is not useful at the moment. If you try to run this package, it will crash, because the Nix codebase currently has lots of problems with handling Windows paths. Even after the big task of fixing paths, we'll have to handle process management, making a useful Windows standard environment, adding tests, and lots of other things.
I think it makes sense to not merge this package, until Nix has a minimal working Windows release. What do you think @Ericson2314?
Fixes #22459.