Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

nix: init at 2.25.0 #22499

Draft
wants to merge 7 commits into
base: master
Choose a base branch
from
Draft

nix: init at 2.25.0 #22499

wants to merge 7 commits into from

Conversation

puffnfresh
Copy link
Contributor

I haven't done a build in a chroot so hopefully I got all the dependencies.

The output executable is not useful at the moment. If you try to run this package, it will crash, because the Nix codebase currently has lots of problems with handling Windows paths. Even after the big task of fixing paths, we'll have to handle process management, making a useful Windows standard environment, adding tests, and lots of other things.

I think it makes sense to not merge this package, until Nix has a minimal working Windows release. What do you think @Ericson2314?

Fixes #22459.

@Ericson2314
Copy link
Contributor

Yeah fine with me just keeping this draft for now.

@puffnfresh puffnfresh marked this pull request as draft November 12, 2024 01:43
@ognevny
Copy link
Collaborator

ognevny commented Nov 12, 2024

CLANG64 fails with:

FAILED: src/libutil/libnixutil.dll.p/windows_environment-variables.cc.obj 
  "clang++" "-Isrc/libutil/libnixutil.dll.p" "-Isrc/libutil" "-I../nix-2.25.0/src/libutil" "-Isrc/libutil/windows" "-I../nix-2.25.0/src/libutil/windows" "-fdiagnostics-color=always" "-D_LIBCPP_HARDENING_MODE=_LIBCPP_HARDENING_MODE_FAST" "-D_FILE_OFFSET_BITS=64" "-Wall" "-Winvalid-pch" "-std=c++2a" "-include" "config-util.hh" "-Wdeprecated-copy" "-Werror=suggest-override" "-Werror=switch" "-Werror=switch-enum" "-Werror=unused-result" "-Wignored-qualifiers" "-Wimplicit-fallthrough" "-Wno-deprecated-declarations" "-D_WIN32_WINNT=0x0602" "-march=nocona" "-msahf" "-mtune=generic" "-O2" "-pipe" "-Wp,-D_FORTIFY_SOURCE=2" "-fstack-protector-strong" "-Wp,-D__USE_MINGW_ANSI_STDIO=1" "-DBOOST_CONTEXT_DYN_LINK=1" "-DBOOST_COROUTINES_DYN_LINK=1" "-DBOOST_ALL_NO_LIB" "-pthread" -MD -MQ src/libutil/libnixutil.dll.p/windows_environment-variables.cc.obj -MF "src/libutil/libnixutil.dll.p/windows_environment-variables.cc.obj.d" -o src/libutil/libnixutil.dll.p/windows_environment-variables.cc.obj "-c" ../nix-2.25.0/src/libutil/windows/environment-variables.cc
  ../nix-2.25.0/src/libutil/windows/environment-variables.cc:16:31: error: non-constant-expression cannot be narrowed from type 'DWORD' (aka 'unsigned long') to 'wchar_t' in initializer list [-Wc++11-narrowing]
     16 |     std::wstring value{L'\0', bufferSize};
        |                               ^~~~~~~~~~
  ../nix-2.25.0/src/libutil/windows/environment-variables.cc:16:31: note: insert an explicit cast to silence this issue
  
     16 |     std::wstring value{L'\0', bufferSize};
  
        |                               ^~~~~~~~~~
  
        |                               static_cast<wchar_t>( )
  
  1 error generated.

mingw-w64-nix/PKGBUILD Outdated Show resolved Hide resolved
Ericson2314 added a commit to nix-windows/nix that referenced this pull request Nov 12, 2024
Ericson2314 added a commit to nix-windows/nix that referenced this pull request Nov 12, 2024
Co-authored-by: Maksim Bondarenkov <[email protected]>
mergify bot pushed a commit to NixOS/nix that referenced this pull request Nov 12, 2024
See the build failure in msys2/MINGW-packages#22499

(cherry picked from commit 355f08a)

# Conflicts:
#	src/libutil/windows/environment-variables.cc
@Ericson2314
Copy link
Contributor

NixOS/nix#11856 OK this would fix the one build failure.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add Nix
3 participants