-
Notifications
You must be signed in to change notification settings - Fork 1.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
godot: update to 4.3 #22355
base: master
Are you sure you want to change the base?
godot: update to 4.3 #22355
Conversation
the build issue seems to be this one: godotengine/godot#97882 |
Oh thank you for finding that out, I was desperately digging other sources and not realize this. I will now work on a fix as soon as possible. |
What's the reasoning behind removing all the dependencies? |
Godot also provides sources of those libraries in their repository. Since MSYS2 only provides the binary package of the engine; I think it is better to use their specific version of those libraries to avoid potential compability issues. |
Hm, ok. Normally we try to use system libs if that is supported upstream, so it also includes our patches and gets security updates more easily. But if they support this setup and it makes maintenance easier (given no one bothered to update it in a while) we could make an exception. |
I see, then I will try to make using external libs possible in the next following days. |
It is desirable to use system libs (libraries provided by msys2 rather than vendored libraries for packaging purposes), in case of bugs we can raise bug reports or patch the code itself. |
It now depends on MSYS2 libs, but a few of them are still compiled using godot's sources. Because those libraries are not presented in MSYS2 repository or they require too many patches to work. Comparing to the official build, this build is linked dynamicly againts required libraries. |
Co-authored-by: Kreijstal <[email protected]>
Update to the lastest godot game engine, PKGBUILD is modofied from Arch Linux repo.