Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

godot: update to 4.3 #22355

Open
wants to merge 5 commits into
base: master
Choose a base branch
from

Conversation

felixaszx
Copy link
Contributor

Update to the lastest godot game engine, PKGBUILD is modofied from Arch Linux repo.

@felixaszx felixaszx changed the title update godot to godot-4.3-stable godot: update to 4.3 Oct 30, 2024
@felixaszx felixaszx marked this pull request as draft October 30, 2024 23:17
@lazka
Copy link
Member

lazka commented Nov 2, 2024

the build issue seems to be this one: godotengine/godot#97882

@felixaszx
Copy link
Contributor Author

the build issue seems to be this one: godotengine/godot#97882

Oh thank you for finding that out, I was desperately digging other sources and not realize this. I will now work on a fix as soon as possible.

@felixaszx felixaszx marked this pull request as ready for review November 2, 2024 22:28
@lazka
Copy link
Member

lazka commented Nov 9, 2024

What's the reasoning behind removing all the dependencies?

@felixaszx
Copy link
Contributor Author

felixaszx commented Nov 9, 2024

What's the reasoning behind removing all the dependencies?

Godot also provides sources of those libraries in their repository. Since MSYS2 only provides the binary package of the engine; I think it is better to use their specific version of those libraries to avoid potential compability issues.

@lazka
Copy link
Member

lazka commented Nov 16, 2024

Hm, ok. Normally we try to use system libs if that is supported upstream, so it also includes our patches and gets security updates more easily. But if they support this setup and it makes maintenance easier (given no one bothered to update it in a while) we could make an exception.

@felixaszx
Copy link
Contributor Author

Hm, ok. Normally we try to use system libs if that is supported upstream, so it also includes our patches and gets security updates more easily. But if they support this setup and it makes maintenance easier (given no one bothered to update it in a while) we could make an exception.

I see, then I will try to make using external libs possible in the next following days.

@Kreijstal
Copy link
Contributor

Hm, ok. Normally we try to use system libs if that is supported upstream, so it also includes our patches and gets security updates more easily. But if they support this setup and it makes maintenance easier (given no one bothered to update it in a while) we could make an exception.

I see, then I will try to make using external libs possible in the next following days.

It is desirable to use system libs (libraries provided by msys2 rather than vendored libraries for packaging purposes), in case of bugs we can raise bug reports or patch the code itself.

@felixaszx felixaszx marked this pull request as draft November 19, 2024 16:55
@felixaszx felixaszx marked this pull request as ready for review November 19, 2024 20:33
@felixaszx
Copy link
Contributor Author

It now depends on MSYS2 libs, but a few of them are still compiled using godot's sources. Because those libraries are not presented in MSYS2 repository or they require too many patches to work.

Comparing to the official build, this build is linked dynamicly againts required libraries.

mingw-w64-godot/PKGBUILD Outdated Show resolved Hide resolved
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants