libobjc2: Build with strict Apple compatibility, backport fix #22538
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
That's coming from mingw-w64 btw. https://github.com/mingw-w64/mingw-w64/blob/cf5c50cce0b4f8610eafd95443d1d3767de386a5/mingw-w64-headers/include/minwindef.h#L127 |
ognevny
reviewed
Nov 15, 2024
By default, Objective C's `BOOL` type is an `(un)signed char`. libobjc2 would define BOOL as `int` on the Windows platform, to avoid a clash with the Windows `BOOL` type. However, MSYS2 uses `WINBOOL` instead of `BOOL` to avoid this clash. Hence: - Align the libobjc2 configuration with the Apple and use libobjc2 with the `STRICT_APPLE_COMPATIBILITY=1` flag set. This aligns with the behavior of the GCC libobjc runtime. - Configure `gnustep-make` with `CFLAGS=-DSTRICT_APPLE_COMPATIBILITY=1` to make sure GNUstep picks up this configuration - Rebuild the other GNUstep packages
qmfrederik
force-pushed
the
libobjc2-strict
branch
from
c31c385
to
5ee1c99
Compare
qmfrederik
force-pushed
the
libobjc2-strict
branch
from
9fcb472
to
2d6e4e6
Compare
qmfrederik
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR backports two fixes for libobjc2:
BOOL type compatibility
By default, Objective C's
BOOLtype is an(un)signed char. libobjc2 would define BOOL asinton the Windows platform, to avoid a clash with the WindowsBOOLtype.However, MSYS2 uses
WINBOOLinstead ofBOOLto avoid this clash.Hence:
STRICT_APPLE_COMPATIBILITY=1flag set. This aligns with the behavior of the GCC libobjc runtime.gnustep-makewithCFLAGS=-DSTRICT_APPLE_COMPATIBILITY=1to make sure GNUstep picks up this configurationFix for selector forwarding on x64 Windows
Backport of gnustep/libobjc2#313