Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[core] Update lerna to 5.2.0 #33635

Merged
merged 1 commit into from
Jul 27, 2022
Merged

[core] Update lerna to 5.2.0 #33635

merged 1 commit into from
Jul 27, 2022

Conversation

michaldudak
Copy link
Member

@michaldudak michaldudak commented Jul 25, 2022 •
edited
Loading

Updated lerna to 5.2.0 and used nx to run tasks.

@michaldudak michaldudak added the core Infrastructure work going on behind the scenes label Jul 25, 2022
@michaldudak michaldudak requested a review from a team July 25, 2022 08:35
@siriwatknp siriwatknp mentioned this pull request Jul 25, 2022
Closed
1 task
@siriwatknp siriwatknp added the security Pull requests that address a security vulnerability label Jul 25, 2022
@mui-bot
Copy link

mui-bot commented Jul 25, 2022 •
edited
Loading

No bundle size changes

Generated by 🚫 dangerJS against fafd5f0

@michaldudak michaldudak force-pushed the update-lerna branch 2 times, most recently from 0b22559 to 4fab481 Compare July 25, 2022 10:56
@michaldudak michaldudak marked this pull request as ready for review July 25, 2022 11:37
oliviertassinari
oliviertassinari reviewed Jul 25, 2022
View reviewed changes
.codesandbox/ci.json Outdated
@@ -1,7 +1,7 @@
{
"buildCommand": "build:codesandbox",
"installCommand": "install:codesandbox",
"node": "12",
"node": "16",
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It could be good to have a standalone PR like in mui/mui-x#4999

@github-actions github-actions bot added the PR: out-of-date The pull request has merge conflicts and can't be merged label Jul 26, 2022
@github-actions github-actions bot added PR: out-of-date The pull request has merge conflicts and can't be merged and removed PR: out-of-date The pull request has merge conflicts and can't be merged labels Jul 26, 2022
@github-actions github-actions bot added PR: out-of-date The pull request has merge conflicts and can't be merged and removed PR: out-of-date The pull request has merge conflicts and can't be merged labels Jul 26, 2022
@michaldudak michaldudak mentioned this pull request Jul 26, 2022
Closed
1 task
siriwatknp
siriwatknp approved these changes Jul 27, 2022
View reviewed changes
Copy link
Member

@siriwatknp siriwatknp left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@github-actions github-actions bot added PR: out-of-date The pull request has merge conflicts and can't be merged and removed PR: out-of-date The pull request has merge conflicts and can't be merged labels Jul 27, 2022
@github-actions github-actions bot removed the PR: out-of-date The pull request has merge conflicts and can't be merged label Jul 27, 2022
@michaldudak michaldudak merged commit c04480d into mui:master Jul 27, 2022
@michaldudak michaldudak deleted the update-lerna branch July 27, 2022 09:14
cherniavskii
cherniavskii reviewed Aug 12, 2022
View reviewed changes
lerna.json
@@ -1,5 +1,6 @@
{
"npmClient": "yarn",
"useWorkspaces": true,
"version": "independent"
"version": "independent",
"useNx": true
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@michaldudak Curious how it worked out - are there any benefits of using nx?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I haven't noticed any improvements in build times, but we now get a nicer preview of what's being built/checked when running locally.

Copy link
Member

@oliviertassinari oliviertassinari Aug 12, 2022 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looking at https://nx.dev/migration/lerna-and-nx#speed-up-lerna-with-nx's-powerful-task-scheduler, we are already running all the tasks in parallel, a smarter scheduler has no room for optimizations.

For the cache, maybe it's a bug? I mean if we don't publish @mui/styles, why build it? But then, maybe we don't care, it takes ~60s, once a week, and no cache might help, it avoid nasty bugs of implicit dependencies.

@snyk-bot snyk-bot mentioned this pull request Nov 5, 2022
Open
@hzhz hzhz mentioned this pull request Nov 16, 2022
Open
@hzhz hzhz mentioned this pull request Nov 29, 2022
Open
daniel-rabe pushed a commit to daniel-rabe/material-ui that referenced this pull request Nov 29, 2022
@michaldudak
[core] Update lerna to 5.2.0 (mui#33635)
f37af20
@hzhz hzhz mentioned this pull request Dec 26, 2022
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@oliviertassinari oliviertassinari oliviertassinari left review comments

@cherniavskii cherniavskii cherniavskii left review comments

@siriwatknp siriwatknp siriwatknp approved these changes

Assignees
No one assigned
Labels
core Infrastructure work going on behind the scenes security Pull requests that address a security vulnerability
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@michaldudak @mui-bot @oliviertassinari @cherniavskii @siriwatknp