-
-
Notifications
You must be signed in to change notification settings - Fork 32.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Box] Fix usage of not supported features in TypeScript 3.5 #35877
Conversation
…he minimal supported version
|
We definitely should have a test suite for old TS versions, as these errors are pretty hard to spot during reviews. It happened a few times before that we shipped something that wasn't supported in 3.5. |
@mnajdova The issue seems to be with how we called I have added this as an idea for #30660. |
That's correct. And as my project was running on TS |
I see, nice to know. |
Fixes #35860. This is a regression from #35532, as
ReturnType
is not supported in TypeScript 3.5