Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[data grid] Remove dead logic to support Safari < 13 #13249

Merged
merged 1 commit into from
May 27, 2024

Conversation

oliviertassinari
Copy link
Member

@oliviertassinari oliviertassinari commented May 25, 2024

Since MUI X v7 is supposed to have the same browser support as Material UI v6 mui/material-ui#40958. So support Safari >= 15.4. I'm removing code that is well supposed in that range: https://caniuse.com/css-touch-action.

Less code, faster parse time, faster rendering.

I saw this from working on #13248.

@oliviertassinari oliviertassinari added component: data grid This is the name of the generic UI component, not the React module! performance labels May 25, 2024
@oliviertassinari oliviertassinari changed the title [data grid] Remove dead logic to support Safari <13 [data grid] Remove dead logic to support Safari < 13 May 25, 2024
@mui-bot
Copy link

mui-bot commented May 25, 2024

Deploy preview: https://deploy-preview-13249--material-ui-x.netlify.app/

Generated by 🚫 dangerJS against fc211ce

@MBilalShafi MBilalShafi changed the title [data grid] Remove dead logic to support Safari < 13 [DataGrid] Remove dead logic to support Safari < 13 May 26, 2024
@oliviertassinari oliviertassinari changed the title [DataGrid] Remove dead logic to support Safari < 13 [data grid] Remove dead logic to support Safari < 13 May 27, 2024
@oliviertassinari oliviertassinari merged commit 290c724 into mui:master May 27, 2024
19 checks passed
@oliviertassinari oliviertassinari deleted the remove-dead-logic-v2 branch May 27, 2024 10:45
DungTiger pushed a commit to DungTiger/mui-x that referenced this pull request Jul 23, 2024
thomasmoon pushed a commit to thomasmoon/mui-x that referenced this pull request Sep 9, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
component: data grid This is the name of the generic UI component, not the React module! performance
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants