New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[data grid][pickers][tree-view] Fix shortcut with localization keyboard #14220

Merged

oliviertassinari merged 5 commits into mui:master from rotembarsela:clipboard-copy-paste-cols

Oct 16, 2024

Contributor

rotembarsela commented Aug 15, 2024 •

edited by oliviertassinari

Loading

Closes #14219

We also fix the date picker and tree view shortcuts.

mui-bot commented Aug 15, 2024 •

edited

Loading

Deploy preview: https://deploy-preview-14220--material-ui-x.netlify.app/

Generated by 🚫 dangerJS against a3850fa

rotembarsela changed the title ~~[DataGrid] fix copy paste cells with localization keyboard~~ [DataGridPremium] fix copy paste cells with localization keyboard

zannager added the component: data grid label

michelengelen reviewed

View reviewed changes

packages/x-data-grid/src/utils/keyboardUtils.ts Outdated Show resolved Hide resolved

packages/x-data-grid/src/utils/keyboardUtils.ts Show resolved Hide resolved

michelengelen requested review from arminmeh, MBilalShafi and cherniavskii

August 15, 2024 14:52

oliviertassinari previously requested changes

View reviewed changes

packages/x-data-grid/src/utils/keyboardUtils.ts Outdated Show resolved Hide resolved

oliviertassinari reviewed

View reviewed changes

packages/x-data-grid-premium/src/hooks/features/clipboard/useGridClipboardImport.ts Outdated Show resolved Hide resolved

oliviertassinari changed the title ~~[DataGridPremium] fix copy paste cells with localization keyboard~~ [DataGridPremium] Fix copy paste cells with localization keyboard

oliviertassinari added bug 🐛 regression labels

rotembarsela requested a review from oliviertassinari

August 18, 2024 05:47

oliviertassinari reviewed

View reviewed changes

packages/x-data-grid-premium/src/hooks/features/aggregation/gridAggregationInterfaces.ts Outdated Show resolved Hide resolved

oliviertassinari reviewed

View reviewed changes

scripts/x-data-grid-premium.exports.json Outdated Show resolved Hide resolved

oliviertassinari reviewed

View reviewed changes

scripts/README.md Outdated Show resolved Hide resolved

oliviertassinari reviewed

View reviewed changes

packages/x-data-grid/src/utils/keyboardUtils.ts Show resolved Hide resolved

oliviertassinari reviewed

View reviewed changes

packages/x-data-grid/src/utils/keyboardUtils.ts Outdated Show resolved Hide resolved

oliviertassinari dismissed their stale review

August 18, 2024 12:17

Initial concern solved

oliviertassinari changed the title ~~[DataGridPremium] Fix copy paste cells with localization keyboard~~ [DataGrid] Fix copy paste cells with localization keyboard

Member

oliviertassinari commented Aug 18, 2024 •

edited

Loading

I have added some comments to help in the future, we have had so many iterations of this logic, so to make sure we build up. This looks good 👍, I have unsubscribed to notifications.

For those curious about pushing it even further: w3c/uievents#377.

This was referenced Aug 18, 2024

Need virtual key codes w3c/uievents#377

Open

[docs-infra] Fix copy shortcut mui/material-ui#43361

Merged

Member

oliviertassinari commented Aug 19, 2024

The date picker has the same problem:

mui-x/packages/x-date-pickers/src/internals/hooks/useField/useField.ts

Line 128 in b217a27

event.key.toLowerCase() === 'a' &&

Contributor Author

rotembarsela commented Aug 19, 2024 •

edited by oliviertassinari

Loading

The date picker has the same problem:

mui-x/packages/x-date-pickers/src/internals/hooks/useField/useField.ts

Line 128 in b217a27

event.key.toLowerCase() === 'a' &&

isPasteShortcut func has the same problem when trying to paste after the CTRL+C event,
https://github.com/mui/mui-x/blob/master/packages/x-data-grid/src/utils/keyboardUtils.ts


          fix copy paste cells with localization keyboard

f76b916

oliviertassinari force-pushed the clipboard-copy-paste-cols branch 2 times, most recently from bd9dc9d to 7f065f2 Compare

October 8, 2024 23:38


          polish

oliviertassinari changed the title ~~[DataGrid] Fix copy paste cells with localization keyboard~~ [data grid] Fix copy paste cells with localization keyboard


          more fixes

02ac942

oliviertassinari force-pushed the clipboard-copy-paste-cols branch from 7f065f2 to 02ac942 Compare

October 8, 2024 23:47

oliviertassinari approved these changes

View reviewed changes

Member

oliviertassinari left a comment

This looks good on my end


          update test

471311f

oliviertassinari force-pushed the clipboard-copy-paste-cols branch 3 times, most recently from 68570fe to 3ed8508 Compare

October 9, 2024 10:16


          fix tests

a3850fa

oliviertassinari force-pushed the clipboard-copy-paste-cols branch from 3ed8508 to a3850fa Compare

October 9, 2024 10:16

oliviertassinari added component: pickers component: tree view labels

oliviertassinari changed the title ~~[data grid] Fix copy paste cells with localization keyboard~~ [data grid][pickers][tree-view Fix shortcut with localization keyboard

oliviertassinari changed the title ~~[data grid][pickers][tree-view Fix shortcut with localization keyboard~~ [data grid][pickers][tree-view] Fix shortcut with localization keyboard

oliviertassinari merged commit 462de3e into mui:master

22 checks passed

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

michelengelen michelengelen left review comments

oliviertassinari oliviertassinari approved these changes

arminmeh Awaiting requested review from arminmeh

MBilalShafi Awaiting requested review from MBilalShafi

cherniavskii Awaiting requested review from cherniavskii

Labels

bug 🐛 component: data grid component: pickers component: tree view regression