Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[core] Update monorepo #6180

Merged
merged 2 commits into from
Sep 16, 2022
Merged

Conversation

flaviendelangle
Copy link
Member

@mui-bot
Copy link

mui-bot commented Sep 16, 2022

These are the results for the performance tests:

Test case Unit Min Max Median Mean σ
Filter 100k rows ms 506 916.5 682.2 674.96 145.325
Sort 100k rows ms 638.4 1,042.2 859.2 904.86 146.448
Select 100k rows ms 205.4 302.1 236.9 249.66 35.902
Deselect 100k rows ms 138.1 251 193.3 187.62 40.66

Generated by 🚫 dangerJS against ff0ad5b

@@ -82,7 +82,7 @@
"@mnajdova/enzyme-adapter-react-18": "^0.2.0",
"@mui/icons-material": "^5.10.3",
"@mui/material": "^5.10.4",
"@mui/monorepo": "https://github.com/m4theushw/material-ui.git#master",
"@mui/monorepo": "https://github.com/flaviendelangle/material-ui.git#master",
Copy link
Member

@oliviertassinari oliviertassinari Sep 16, 2022

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Shouldn't it be?

Suggested change
"@mui/monorepo": "https://github.com/flaviendelangle/material-ui.git#master",
"@mui/monorepo": "https://github.com/mui/material-ui.git#master",

I plan to merge mui/material-ui#34259, I will need it to be on the main release line.

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The problem is that, unless it has been fixed and I don't know, the codesandbox cache of the mui repo is still broken.
It's the problem when migrating Argos.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I created codesandbox/codesandbox-ci-ui#49 but I don't hope they will implement this. There're issues from last year without any comment in this repo.

Copy link
Member

@oliviertassinari oliviertassinari Sep 17, 2022

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Oh, I see. I think that I could solve the issue. See the build history at https://ci.codesandbox.io/status/mui/mui-x/pr/5938.

  • 294382 failed, I started to look at a fix
  • 294385 failed again with the first attempt I did
  • 294386 passed with the second attempt I did 0d204c9
  • 294388 still passed with a git revert of 0d204c9

So I went ahead I opened #6188, #6189 for our two base branches.

@flaviendelangle flaviendelangle merged commit 4ad1c16 into mui:next Sep 16, 2022
@flaviendelangle flaviendelangle deleted the monorepo-ttp branch November 18, 2022 07:04
@oliviertassinari oliviertassinari added the core Infrastructure work going on behind the scenes label Jan 17, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
core Infrastructure work going on behind the scenes
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants