-
-
Notifications
You must be signed in to change notification settings - Fork 1.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[core] Update monorepo #6180
[core] Update monorepo #6180
Conversation
These are the results for the performance tests:
|
@@ -82,7 +82,7 @@ | |||
"@mnajdova/enzyme-adapter-react-18": "^0.2.0", | |||
"@mui/icons-material": "^5.10.3", | |||
"@mui/material": "^5.10.4", | |||
"@mui/monorepo": "https://github.com/m4theushw/material-ui.git#master", | |||
"@mui/monorepo": "https://github.com/flaviendelangle/material-ui.git#master", |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Shouldn't it be?
"@mui/monorepo": "https://github.com/flaviendelangle/material-ui.git#master", | |
"@mui/monorepo": "https://github.com/mui/material-ui.git#master", |
I plan to merge mui/material-ui#34259, I will need it to be on the main release line.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The problem is that, unless it has been fixed and I don't know, the codesandbox cache of the mui
repo is still broken.
It's the problem when migrating Argos.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I created codesandbox/codesandbox-ci-ui#49 but I don't hope they will implement this. There're issues from last year without any comment in this repo.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Oh, I see. I think that I could solve the issue. See the build history at https://ci.codesandbox.io/status/mui/mui-x/pr/5938.
- 294382 failed, I started to look at a fix
- 294385 failed again with the first attempt I did
- 294386 passed with the second attempt I did 0d204c9
- 294388 still passed with a git revert of 0d204c9
So I went ahead I opened #6188, #6189 for our two base branches.
I need mui/material-ui#34311 for #6070