Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[DataGrid] Remove disableIgnoreModificationsIfProcessingProps prop #6640

Merged
merged 2 commits into from
Oct 31, 2022

Conversation

m4theushw
Copy link
Member

Part of #3287

Changelog

Breaking changes

  • The disableIgnoreModificationsIfProcessingProps prop was removed and its behavior when true was incorporated as the default behavior. The old behavior can be restored by using apiRef.current.stopRowEditMode({ ignoreModifications: true }) or apiRef.current.stopCellEditMode({ ignoreModifications: true }).

@m4theushw m4theushw added breaking change component: data grid This is the name of the generic UI component, not the React module! labels Oct 26, 2022
@mui-bot
Copy link

mui-bot commented Oct 26, 2022

Messages
📖 Netlify deploy preview: https://deploy-preview-6640--material-ui-x.netlify.app/

These are the results for the performance tests:

Test case Unit Min Max Median Mean σ
Filter 100k rows ms 666.8 1,088.2 687.9 838.68 157.188
Sort 100k rows ms 604 1,193.8 604 911.36 198.748
Select 100k rows ms 182.6 314.8 271.4 261.42 44.555
Deselect 100k rows ms 159.7 283.3 207.9 226 46.244

Generated by 🚫 dangerJS against e30574c

@github-actions github-actions bot added the PR: out-of-date The pull request has merge conflicts and can't be merged label Oct 31, 2022
@github-actions
Copy link

This pull request has conflicts, please resolve those before we can evaluate the pull request.

@github-actions github-actions bot removed the PR: out-of-date The pull request has merge conflicts and can't be merged label Oct 31, 2022
@m4theushw m4theushw merged commit fc53820 into mui:next Oct 31, 2022
@m4theushw m4theushw deleted the stop-ignoring-modifications-by-default branch October 31, 2022 20:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
breaking change component: data grid This is the name of the generic UI component, not the React module!
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants