Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Accessibility improvements #85

Open
wants to merge 3 commits into
base: master
Choose a base branch
from
Open

Conversation

vvillenave
Copy link

Greetings,
this is a proposal for some accessibility improvements (mainly labelling).
A rather big remaining issue is that the status columns in the TreeView
are still not exposed, and that the context menu for packages still isn’t
accessible through keyboard input. But I’m gonna tackle that another
time hopefully...

@vvillenave
Copy link
Author

Guys, any comments on this PR? @mvo5? @BryanQuigley?

@BryanQuigley
Copy link
Contributor

These are generic comments - I'm not using synaptic atm - doing some distro hopping... anyway.. (and wait to see what @mvo5 says before making any big changes)

FIXMEs I would drop all changes to the files you don't think are used any make a separate list of them (and maybe another PR to remove them.

In my limited understanding:
"Accessibility: add proper labelling relations" looks like it really couldn't cause any regressions.
while the other two could potentially cause regressions. - Might be worth separate PRs.

@hamishmb
Copy link

I'm not a contributor here, but this looks like a decent set of changes to me. I concur that the labelling seems unlikely to cause any issues.

I'm not sure why the invisible cursor improves accessibility though - I often find it confusing when the cursor isn't visible, especially if I'm controlling a system over eg VNC.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants