refactor(core): Extract execute-single context out of NodeExecutionFunctions (no-changelog) #11543

netroy · 2024-11-04T16:07:50Z

Summary

This PR extracts ExecuteSingle context object out of NodeExecutionFunctions, and adds unit tests for most of this code.

PR title and summary are descriptive. (conventions)
Docs updated or follow-up ticket created.
Tests included.
PR Labeled with release/backport (if the PR is an urgent fix that needs to be backported)

…unctions (no-changelog)

codecov · 2024-11-05T19:57:18Z

Attention: Patch coverage is 77.14286% with 16 lines in your changes missing coverage. Please review.

Files with missing lines	Patch %	Lines
...c/node-execution-context/execute-single-context.ts	80.64%	11 Missing and 1 partial ⚠️
packages/workflow/src/RoutingNode.ts	40.00%	3 Missing ⚠️
packages/core/src/NodeExecuteFunctions.ts	50.00%	1 Missing ⚠️

📢 Thoughts on this report? Let us know!

n8n-assistant bot added core Enhancement outside /nodes-base and /editor-ui n8n team Authored by the n8n team labels Nov 4, 2024

netroy force-pushed the CAT-307-extract-execute-single--context branch from 231889c to c51ed26 Compare November 5, 2024 18:19

netroy marked this pull request as ready for review November 5, 2024 18:20

netroy force-pushed the CAT-307-extract-execute-single--context branch from c51ed26 to cb4915d Compare November 5, 2024 18:20

netroy requested a review from tomi November 5, 2024 18:24

netroy added 2 commits November 5, 2024 20:10

refactor(core): Extract execute-single context out of NodeExecutionF…

fcc9f88

…unctions (no-changelog)

don't do destructuring on objects with a prototype chain

8f09c1d

netroy force-pushed the CAT-307-extract-execute-single--context branch from cb4915d to 8f09c1d Compare November 5, 2024 19:32