Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(Auto-fixing Output Parser Node): Only run retry chain on parsing errors #11569

Open
wants to merge 4 commits into
base: master
Choose a base branch
from

Conversation

OlegIvaniv
Copy link
Contributor

Summary

This PR fixes two issues with the OutputParserAutofixing node:

  1. The node uses a hardcoded prompt template which fails to handle complex output formats effectively
  2. The error handling mechanism attempts to fix all errors indiscriminately, including non-parsing related errors (like network issues)

Changes

  • Improved error handling by only retrying on OutputParserException
  • Added option to customize the fix prompt template used in OutputParserAutofixing
  • Added validation for fix prompt template (must contain {error} placeholder)
  • Updated unit tests to cover new functionality and edge cases

Related Linear tickets, Github issues, and Community forum posts

Review / Merge checklist

  • PR title and summary are descriptive. (conventions)
  • Docs updated or follow-up ticket created.
  • Tests included.
  • PR Labeled with release/backport (if the PR is an urgent fix that needs to be backported)

@n8n-assistant n8n-assistant bot added the n8n team Authored by the n8n team label Nov 5, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
n8n team Authored by the n8n team
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant