-
Notifications
You must be signed in to change notification settings - Fork 12
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update theme/style sheet handling to enable napari-console to use napari font_size
setting
#33
base: main
Are you sure you want to change the base?
Conversation
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #33 +/- ##
==========================================
+ Coverage 96.69% 96.77% +0.07%
==========================================
Files 4 4
Lines 121 124 +3
==========================================
+ Hits 117 120 +3
Misses 4 4 ☔ View full report in Codecov by Sentry. |
font_size
settingfont_size
setting
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is not correct approach. You either need to disconnect _update_theme
from self.viewer.events.theme
event or update _update_theme
to read font size from settings
I just installed this PR and I do not see any changes when update theme or font size. I do not see connection to any proper signal in the code |
Did you check this alongside napari/napari#6753 @Czaki ? I checked again and works for me on Windows 🤔 (although as mentioned I see a deprecation warning related with the Anyhow, maybe the work over napari/napari#6753 and here is not the correct approach and these PRs should be closed? |
@Czaki do you want to have another look at this after Daniel's last comment? Should this PR be closed or is it the right approach? |
References and relevant issues
Closes #32
Description
Depends on/related to napari/napari#6753
A preview:
Notes
as_dict
kwarg from theget_theme
function). Added a note about that here.style_sheet
kwarg added to the_update_theme
method defines if the previous logic needs to be used (napari 0.5.0 will use the newstyle_sheet
kwarg, see Usefont_size
setting to controlnapari-console
font-size napari#6753)