Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update reindex.py script to include manifest visibility and exclude packages with no PyPI versions #32

Open
wants to merge 3 commits into
base: main
Choose a base branch
from

Conversation

DragaDoncila
Copy link

Closes #31.

This PR updates the reindexing script to:

  • include the manifest visibility in the extended summary
  • exclude packages with no current PyPI versions from extended summary

Copy link

vercel bot commented Jun 4, 2024

Someone is attempting to deploy a commit to the napari Team on Vercel.

A member of the Team first needs to authorize it.

@DragaDoncila
Copy link
Author

@tlambert03 I'm not sure what's needed here on the vercel side, but would you be able to add/transfer credentials for it in the 1password vault?

Can you also confirm where the changes in this PR will be written i.e. will the workflows actually write to the published public/ folder or do they not write anywhere? I couldn't find an option to toggle the destination based on where the workflow is running.

Copy link

vercel bot commented Jun 4, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
npe2api ✅ Ready (Inspect) Visit Preview 💬 Add feedback Jun 4, 2024 0:24am

@tlambert03
Copy link
Collaborator

Can you also confirm where the changes in this PR will be written i.e. will the workflows actually write to the published public/ folder or do they not write anywhere?

this line writes extended_summary.json to the public folder in this repo. This line commits the changes to the repo

@tlambert03
Copy link
Collaborator

but would you be able to add/transfer credentials for it in the 1password vault?

i'm not sure vercel works like that, but @Czaki is listed as an owner of the team

image

... and it won't let me add more members to the team without upgrading my plan. Since @Czaki already has access, perhaps he can figure out how to share/transfer/whatever. I'm happy to leave the team if it helps. just let me nkow

@tlambert03
Copy link
Collaborator

(in any case, it will always publish on main i think... so you don't need to worry about it. it's only if you want to preview the published page from a PR)

@Czaki
Copy link
Contributor

Czaki commented Jun 4, 2024

Based on this, what I remember and what is suggested by documentation https://vercel.com/docs/accounts/create-a-team it is enough to create vercel account using GitHub authorization and people from core-dev should be added to organization on vercel.

@DragaDoncila
Copy link
Author

Hmmm if I run stuff locally, visibility is there and I can see that the empty pypi version packages are excluded, but if I look at the published preview from vercel the extended summary doesn't have the info... @Czaki ideas?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

npe2api shouldn't list plugins that have been taken down from PyPI/conda-forge
3 participants